Update routeChangeError message #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current UX is to return the user with a popup when the data fails to load and there is a routeChangeError. This is a bit aggressive and confusing to the user. I'm proposing to change this to a log and redirect to 404 as seen in the PR that was merged to master here: sprangular#198
DanielWright
approved these changes
Dec 20, 2016
|
|
||
| if paymentMethods.length == 0 | ||
| alert 'Gateway is not configured in Spree...' | ||
| $log.info 'Gateway is not configured in Spree...' |
Contributor
Author
There was a problem hiding this comment.
@DanielWright Damn, good catch there. Fixed: 5db92dc
|
👍 |
Contributor
Author
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current UX is to return the user with a popup when the data fails to load and there is a routeChangeError. This is a bit aggressive and confusing to the user.
I'm proposing to change this to a log and redirect to 404 as seen in the PR that was merged to
masterhere: #198Since the project is following the latest commit on
discrete-delivery-and-payment, I'm proposing updating this branch specifically for the least amount of friction.