Skip to content

Conversation

@dargmuesli
Copy link
Member

* Initial plan

* Remove 20 request classes, their test classes, and test fixtures

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove deleted request class references and add new library builder methods in SpotifyApi.java

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove deprecated endpoints and add new /me/library endpoints

- Remove 20 deprecated request classes (GET several/top, POST/GET user-specific, PUT/DELETE per-type library)
- Remove corresponding 20 test classes and 12 test fixtures
- Remove 28 builder methods from SpotifyApi.java
- Add SaveToLibraryRequest (PUT /me/library) and RemoveFromLibraryRequest (DELETE /me/library)
- Add saveToLibrary() and removeFromLibrary() builder methods to SpotifyApi.java

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove availableMarkets, externalIds, label, and popularity fields from Album model

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove albumGroup and availableMarkets fields from AlbumSimplified

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove followers and popularity fields from Artist model class

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove availableMarkets, externalIds, linkedFrom, and popularity fields from Track model

Remove field declarations, constructor assignments, getter methods, Builder setter
methods, and JsonUtil deserialization code for the four fields. Also remove unused
imports (CountryCode, ExternalId, TrackLink, Gson) and update toString method.
Update GetTrackRequestTest to remove assertions for removed fields.

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove availableMarkets and linkedFrom fields from TrackSimplified

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove availableMarkets and publisher fields from Show and ShowSimplified

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Remove country, email, followers, and product fields from User model

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Rename tracks/track fields to items/item in Playlist, PlaylistSimplified, and PlaylistTrack

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Fix test compilation errors after model field removals

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Rename playlist JSON fixture fields: tracks→items, track→item

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Add tests for SaveToLibraryRequest and RemoveFromLibraryRequest endpoints

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Update examples directory for API changes and add compile-examples CI step

- Remove 20 example files for deleted endpoints
- Add SaveToLibraryExample and RemoveFromLibraryExample
- Fix pre-existing SavedEpisode import bug in GetUsersSavedEpisodesExample
- Add compile-examples Maven profile to compile examples with project sources
- Add CI step to compile examples during builds

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* Fix Javadoc for renamed playlist fields and add @OverRide to library request execute methods

- PlaylistSimplified.setItems(): update @param tracks → items
- Playlist.setItems(): update Javadoc wording and @param tracks → items
- PlaylistTrack.setItem(): update Javadoc wording and @param track → item
- SaveToLibraryRequest.execute(): add @OverRide annotation
- RemoveFromLibraryRequest.execute(): add @OverRide annotation

Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>

* ci: compile examples by default

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dargmuesli <4778485+dargmuesli@users.noreply.github.com>
Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 43.37349% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.72%. Comparing base (90c6508) to head (761d87d).

Files with missing lines Patch % Lines
...xamples/data/library/RemoveFromLibraryExample.java 0.00% 9 Missing ⚠️
examples/data/library/SaveToLibraryExample.java 0.00% 9 Missing ⚠️
...lin/spotify/model_objects/specification/Album.java 0.00% 5 Missing ⚠️
...mples/data/playlists/GetPlaylistsItemsExample.java 0.00% 4 Missing ⚠️
...odel_objects/specification/PlaylistSimplified.java 57.14% 2 Missing and 1 partial ⚠️
...equests/data/library/RemoveFromLibraryRequest.java 57.14% 0 Missing and 3 partials ⚠️
...fy/requests/data/library/SaveToLibraryRequest.java 78.57% 0 Missing and 3 partials ⚠️
.../spotify/model_objects/specification/Playlist.java 71.42% 1 Missing and 1 partial ⚠️
...elin/spotify/model_objects/specification/User.java 0.00% 2 Missing ⚠️
...y/model_objects/specification/AlbumSimplified.java 0.00% 1 Missing ⚠️
... and 6 more

❗ There is a different number of reports uploaded between BASE (90c6508) and HEAD (761d87d). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (90c6508) HEAD (761d87d)
8 4
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #449       +/-   ##
=============================================
- Coverage     66.64%   49.72%   -16.92%     
+ Complexity      672      579       -93     
=============================================
  Files           184      242       +58     
  Lines          7264     8605     +1341     
  Branches       1151     1050      -101     
=============================================
- Hits           4841     4279      -562     
- Misses         1520     3528     +2008     
+ Partials        903      798      -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dargmuesli dargmuesli deleted the branch master February 11, 2026 15:42
@dargmuesli dargmuesli closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants