Skip to content

Conversation

@bruceadowns
Copy link

@bruceadowns bruceadowns commented Nov 25, 2024

  • expose http connection mgr with backwards compatibility
  • add HttpClientConnectionManager to SpotifyHttpManager.builder
  • add SpotifyHttpManager.Builder.getConnectionManager to handle default

Similar to #375, but providing backwards compatibility to be included in a 8.4.2.

The default usage does not change, however adding support for PoolingHttpClientConnectionManager would look like this:

    var spotifyApi = SpotifyApi.builder()
        .setHttpManager(new SpotifyHttpManager.Builder()
            .setConnectionManager(new PoolingHttpClientConnectionManager())
            .build())
        .setClientId("foo")
        .setClientSecret("bar")
        .build();

* add HttpClientConnectionManager to SpotifyHttpManager.builder
* add getConnectionManager to handle default
@bruceadowns bruceadowns marked this pull request as ready for review November 25, 2024 02:55
Copy link
Member

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. I've built upon this PR in #409 to keep the current builder usage. Please tell me if my changes would work for you too! :)

@dargmuesli dargmuesli merged commit e02b0c1 into spotify-web-api-java:master Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants