Fixed retrieving playlists for a user with a $ symbol in their user id #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
=========================================
Coverage 66.39% 66.39%
Complexity 669 669
=========================================
Files 184 184
Lines 7106 7107 +1
Branches 1146 1146
=========================================
+ Hits 4718 4719 +1
Misses 1483 1483
Partials 905 905 ☔ View full report in Codecov by Sentry. |
dargmuesli
reviewed
Feb 22, 2024
Member
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
Thank you, great catch, looking good!
I'll take care of the versioning, you can remove those changes from the PR and I'll merge it ❤️
Contributor
Author
Done! |
SergioBarbero
force-pushed
the
fix-user-with-dollar-symbol
branch
from
3833831 to
22e372b
Compare
dargmuesli
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.