code cleanup #386
Merged
code cleanup #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
============================================
+ Coverage 66.09% 66.40% +0.30%
- Complexity 664 669 +5
============================================
Files 184 184
Lines 7106 7108 +2
Branches 1146 1146
============================================
+ Hits 4697 4720 +23
+ Misses 1508 1483 -25
- Partials 901 905 +4 ☔ View full report in Codecov by Sentry. |
dargmuesli
reviewed
Jan 26, 2024
Member
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
Thank you! I left some suggestions.
Member
Author
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here #385
This was a lot more underwhelming than I anticipated. After running a project-wide analysis in IntelliJ and getting rid of everything related to the docs and grammar/typos, there were almost no remarks left. I did go ahead and fix those anyway, though.
The only problem was this because I didn't know what else to use here:
Also, there were these vulnerabilities, which I'll best leave up to you (lest I break anything):
