Skip to content

Conversation

@Selbi182
Copy link
Member

@Selbi182 Selbi182 commented Feb 7, 2023

From #328

@codecov-commenter
Copy link

Codecov Report

Merging #329 (b40c699) into develop (c0e4fb0) will decrease coverage by 0.17%.
The diff coverage is 82.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             develop     #329      +/-   ##
=============================================
- Coverage      65.35%   65.18%   -0.17%     
  Complexity       617      617              
=============================================
  Files            177      177              
  Lines           6925     6943      +18     
  Branches        1118     1123       +5     
=============================================
  Hits            4526     4526              
- Misses          1527     1543      +16     
- Partials         872      874       +2     
Impacted Files Coverage Δ
...main/java/se/michaelthelin/spotify/SpotifyApi.java 84.63% <ø> (ø)
.../requests/data/player/GetTheUsersQueueRequest.java 100.00% <ø> (ø)
...n/spotify/model_objects/special/PlaybackQueue.java 78.94% <82.60%> (+8.94%) ⬆️
...tify/model_objects/miscellaneous/Restrictions.java 0.00% <0.00%> (-63.16%) ⬇️
...y/model_objects/specification/AlbumSimplified.java 68.30% <0.00%> (-2.12%) ⬇️
...lin/spotify/model_objects/specification/Track.java 73.88% <0.00%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dargmuesli dargmuesli self-requested a review February 8, 2023 00:35
@dargmuesli
Copy link
Member

dargmuesli commented Feb 8, 2023

Changing Track to IPlaylistItem would be a breaking change requiring release of v8, you agree? (which would not be a problem)

@Selbi182
Copy link
Member Author

Selbi182 commented Feb 8, 2023

If you say so. It doesn't feel like a big enough change to require a new major version fo me, but I can see where you're coming from

@dargmuesli dargmuesli merged commit f74df44 into spotify-web-api-java:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants