SpotifyApi thread safety #411
-
|
Is the following code thread safe? Various users will be queried using their accessToken in various threads. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 10 replies
-
|
I'm pretty sure it is. Do you see any shared state? |
Beta Was this translation helpful? Give feedback.
-
|
Now that I know you think it should be thread safe, let me experiment and see if I can clarify the behavior that I'm seeing. |
Beta Was this translation helpful? Give feedback.
-
|
I'm also experiencing concurrent problems with: The getUsersCurrentlyPlayingTrack return values are mostly correct, but it periodically returns another user's track. |
Beta Was this translation helpful? Give feedback.
-
|
I suspect the static DEFAULT_HTTP_MANAGER is causing incorrect concurrent results, but have no proof. Do you think the reuse of DEFAULT_HTTP_MANAGER would pose a problem to thread safety? |
Beta Was this translation helpful? Give feedback.
-
|
I have been troubleshooting https://github.com/apache/httpcomponents-client, but am not having any luck identifying why it is returning the wrong cache entry. Would you accept a PR that exposes CacheConfig parameters to allow CacheConfig.SharedCache=true? Or do you have other suggestions? |
Beta Was this translation helpful? Give feedback.
-
|
Of course I'd favor a definite source of the issue as you're searching for, but a PR on the shared cache property does not break anything if backwards compatible, so yes, you can give it a go :) |
Beta Was this translation helpful? Give feedback.
-
100% agreed. I am stuck spinning my wheels, and will back log the httpclient5 troubleshooting for now to move forward. Cache-invalidation is a tricky problem. Expect a PR later today (from the US) to expose cache config. |
Beta Was this translation helpful? Give feedback.
-
|
PR #412 |
Beta Was this translation helpful? Give feedback.
PR #412