Issue Report - TestSimpleExecuteAsync for SpotifyApiThreading #377

Shenkeeee · 2023-12-11T12:28:43Z

Shenkeeee
Dec 11, 2023

Hi,

I'd like to report an issue with the executeAsync method for the SpotifyApiThreading class The test, which aims to validate asynchronous execution using CompletableFuture, is currently failing for us. The expected outcome is the completion of CompletableFuture with a non-null result, but the test indicates otherwise. A revision might be requested to ensure the expected functionality of the SpotifyApiThreading class.

Thanks!
Mate

File path: spotify-web-api-java/src/main/java/se/michaelthelin/spotify/SpotifyApiThreading.java
Test custom file path: spotify-web-api-java/src/test/java/se/michaelthelin/spotify/Ta23BravoTests.java (only exists locally, mentioned for recreational purposes)

/**
 * Test: Testing simple asynchronous execution in the SpotifyApiThreading class.
 * Objective: Verifies that CompletableFuture works correctly in the executeAsync method.
 * Expected result: CompletableFuture completes and the result is not null.
 */
@Test
@DisplayName("Testing simple asynchronous execution in the SpotifyApiThreading class")
public void testSimpleExecuteAsync() {
  Callable<Integer> simpleCallable = () -> 42;

  CompletableFuture<Integer> future = SpotifyApiThreading.executeAsync(simpleCallable);

  assertTrue(future.isDone(), "CompletableFuture has completed.");

  assertNotNull(future.join(), "The result is not null.");
}

dargmuesli · 2023-12-12T01:54:12Z

dargmuesli
Dec 12, 2023
Maintainer

Where exactly do you see the TestSimpleExecuteAsync method in this repository?

0 replies

Shenkeeee · 2023-12-12T06:39:29Z

Shenkeeee
Dec 12, 2023
Author

Let me clarify some of the descriptions.

Derived from the home repository, the path of the file is here, in the SpotifyApiThreading method:
spotify-web-api-java/src/main/java/se/michaelthelin/spotify/SpotifyApiThreading.java"

The main issue arises with a CompletableFuture that doesn't seem to complete under normal conditions. Despite being an asynchronous method, allowing other processes to initiate while it is running, it should have normally completed by the time it reaches the isDone method, based on the simplicity of the simpleCallable lambda method.

The isDone is a part of the CompletableFuture class, It should return true, if:
"Returns true if completed in any fashion: normally, exceptionally, or via cancellation."

0 replies

Shenkeeee · 2023-12-12T06:47:20Z

Shenkeeee
Dec 12, 2023
Author

The test itself was created locally by us and was not originally included in the file system. Relatively, it can be found in our file system and potentially be recreated here:

spotify-web-api-java/src/test/java/se/michaelthelin/spotify/Ta23BravoTests.java

If needed, I can provide the whole file, the exact test that fails was provided in the original post.

1 reply

dargmuesli Dec 12, 2023
Maintainer

Ah, I see.

first of all, please use code formatting in your original post so that I can read or copy the code properly.
for issues like the one you describe which include custom code, please create a fork of this repository (as you already seem to have done) and provide a failing test through that fork. You can show the failure e.g. by providing a link to the failing CI run or maybe even just the repository itself. In the best case that repository would only contain the minimal code that would make the issue clear.
also, you can comment directly under my answers instead of creating new sub-threads so this discussion looks a bit more orderly.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Issue Report - TestSimpleExecuteAsync for SpotifyApiThreading #377

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 3 comments 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

Issue Report - TestSimpleExecuteAsync for SpotifyApiThreading #377

Uh oh!

Uh oh!

Shenkeeee Dec 11, 2023

Replies: 3 comments · 1 reply

Uh oh!

dargmuesli Dec 12, 2023 Maintainer

Uh oh!

Shenkeeee Dec 12, 2023 Author

Uh oh!

Uh oh!

Shenkeeee Dec 12, 2023 Author

Uh oh!

dargmuesli Dec 12, 2023 Maintainer

Shenkeeee
Dec 11, 2023

Replies: 3 comments 1 reply

dargmuesli
Dec 12, 2023
Maintainer

Shenkeeee
Dec 12, 2023
Author

Shenkeeee
Dec 12, 2023
Author

dargmuesli Dec 12, 2023
Maintainer