Optional retries feature added #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashah-splunk
commented
Mar 21, 2022
ashah-splunk
commented
- Added optional retries feature provided by user in PR
- Added test case for the optional retries
- Added example for the optional retries
- Added optional retry parameter for existing test cases setup, to prevent CI build failures
Add optional retries to connection attempts
replaced retryBackoff with retryDelay
fantavlik
reviewed
Apr 19, 2022
fantavlik
approved these changes
Apr 19, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Minor comment about calling out that this is blocking/synchronous but in general this looks good!
Updated the comment to specify this works in synchronous/blocking way
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.