Skip to content

Move CI tests in Python SDK to Github Actions from TravisCI #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akaila-splunk merged 4 commits into from
Sep 28, 2021
Merged

Move CI tests in Python SDK to Github Actions from TravisCI #399

akaila-splunk merged 4 commits into from
Sep 28, 2021

Conversation

@akaila-splunk
Copy link
Contributor

@akaila-splunk akaila-splunk commented Sep 24, 2021

  • Added test.yml file for test cases execution on push and PR
  • Remove .travis.yml file

fantavlik
fantavlik requested changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general these changes look good and I don't expect all tests to pass at this point but a number of the jobs are terminating with: Error: The operation was canceled. could you possibly investigate those issues before merging this work? We'll also want to followup once we know which tests are failing and fix or skip those tests after investigating but that can be a followup task. For now I just want to make sure that all tests are being executed and not running into the above error.

@akaila-splunk
Update test.yml
261a943 
- set fail-fast: false so GitHub will not cancels all in-progress jobs if any matrix job fails.
@akaila-splunk
Copy link
Contributor Author

akaila-splunk commented Sep 27, 2021 •
edited
Loading

GitHub cancels all in-progress jobs with error Error: The operation was canceled if any matrix job fails. that's the reason we are getting this error for other jobs when one of the job fails.
I have changed code as suggested and now all the jobs are running even if any job fails.

@fantavlik
Copy link
Contributor

fantavlik commented Sep 27, 2021

GitHub cancels all in-progress jobs with error Error: The operation was canceled if any matrix job fails. that's the reason we are getting this error for other jobs when one of the job fails.
I have changed code as suggested and now all the jobs are running even if any job fails.

Excellent, that's good to know - thanks for investigating.

fantavlik
fantavlik approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work - let's merge this. Can you also create a followup ticket to address the test failures now that we can see those? That will be high priority.

@akaila-splunk
Copy link
Contributor Author

akaila-splunk commented Sep 28, 2021

Awesome work - let's merge this. Can you also create a followup ticket to address the test failures now that we can see those? That will be high priority.

Sure, I'll create ticket for test failures.

@akaila-splunk akaila-splunk merged commit 709806e into develop Sep 28, 2021
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Nov 1, 2021
Merged
@akaila-splunk akaila-splunk deleted the DVPL-10027 branch May 2, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akaila-splunk @fantavlik