Release 0.11.0 - #62
Merged
Merged
Conversation
akaila-splunk
commented
Jul 23, 2021
akaila-splunk
commented
Contributor
- Update all dependencies to latest stable version and replace deprecated dependencies
- make library compatible with node version 10.0 and 14.0 and Splunk version 8.0 and 8.2.0
- Configured GitHub action for test and release
- Update library to use 'make up' and 'make test' convention
Add NodeJS and Splunk versions tested for compatibility https://jira.splunk.com/browse/DVPL-7485
Revise README
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.12 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.0.12...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>
…-4.5.3 Bump handlebars from 4.0.12 to 4.5.3
Revise link to contact us (no more support@splunk.com).
…er instance Dockerized make up, make test commands for local and CI -- makefile, docker-compose.yml, test_specific.sh Upgraded dependencies Replaced deprecated dependencies such as "request" and "istanbul" with "needle" and "nyc"
Dependency upgrades with Project updated to use Make with Splunk docker instance As discussed, merging this PR based on one Approval
GitHub actions for Test execution
Extra on property
Trying with passing value to makefile
- Testing release to NPM using GitHub action for v0.0.1-beta
Configured GitHub Action for Test Execution
Configured GitHub actions for release to NPM
Update CONTRIBUTING.md
CREDITS.md file added along with Node 10.0 version addition in the CI matrix
fantavlik
requested changes
Jul 26, 2021
fantavlik
left a comment
fantavlik
left a comment
Contributor
There was a problem hiding this comment.
Looking good so far, I left comments in the review but two things to take care of:
- Need to add a new section to the CHANGELOG.md for this new release (notes on what to add to various sections are in the review below)
- Let's remove the .travis.yml since that's no longer used
| */ | ||
|
|
||
| var request = require("request"); | ||
| var needle = require("needle"); |
Contributor
There was a problem hiding this comment.
- Let's add an item to the CHANGELOG.md for this - under
New features & APIs: Replaced client implementation to useneedlein lieu of deprecatedrequest
Contributor
Author
There was a problem hiding this comment.
Updated CHANGELOG.md file as suggested.
| @@ -0,0 +1,20 @@ | |||
| name: Create Release | |||
Contributor
There was a problem hiding this comment.
- Let's add an item to the CHANGELOG.md for this - under
Minor changes: Converted CI from Travis to Github Actions and added CD
Contributor
Author
There was a problem hiding this comment.
Updated CHANGELOG.md file as suggested.
| - echo password=changed! >> $HOME/.splunkrc | ||
| # Set SPLUNK_HOME | ||
| - export SPLUNK_HOME="/opt/splunk" | ||
| # Pull docker image |
Contributor
There was a problem hiding this comment.
Can we remove the .travis.yml file actually? Feel free to do that in this PR
Contributor
Author
There was a problem hiding this comment.
Removed .travis.yml flie.
Contributor
Author
Updated CHANGELOG.md file as suggested and removed .travis.yml file. |
fantavlik
approved these changes
Jul 27, 2021
fantavlik
left a comment
fantavlik
left a comment
Contributor
There was a problem hiding this comment.
Looking good, thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.