feat(SplunkLogger): Add requestOptions parameter - #16
Conversation
|
We need to support non-es6 versions of Node. That's the only thing blocking me from merging this - however I can't promise a release anytime soon due to tight engineering resources |
fdec21e to
dce4cb2
Compare
|
@shakeelmohamed I've re-rolled the commit to not use ES6 features. Let me know if you want me to change anything else. |
|
Thanks @elliotttf. I updated the jshint config, if you merge/rebase from the develop branch you'll see a couple indent issues to fix. How urgently do you need a release with this change? |
This will allow `requestOptions` to be passed into the constructor
rather than requiring modifications after instantiation. This is
particularly useful for assigning multiple options at once, e.g.
```javascript
const logger = new SplunkLogger(config, {
agent: new https.Agent(),
strictSSL: true,
timeout: 150,
});
```
|
@shakeelmohamed fixed! It's not urgent but definitely a nice to have. Specifically I'm interested in this so that I have finer grain control over the socket pool that my application uses to communicate with splunk's servers. It's still possible to do that without this change, just not as convenient 😄 |
|
+1 |
|
@elliotttf We've dropped support for pre-4.0 version of Node so we'd be happy to take this PR now! Can you merge the latest develop into your branch so CI runs? |
|
Any update on when this might get merged? Our team is patching the package locally for the time being. Thanks! |
|
@shakeelmohamed or any other maintainer, looks like this one is ready to go when you have a moment to review. Thank you! |
|
Hi all, Shakeel is no longer one of the maintainers of this project. |
|
Hey splunk team (@ncanumalla-splunk, @ashah-splunk ), any update on when this might get merged? My team appreciates it! |
7 participants
This will allow
requestOptionsto be passed into the constructor rather than requiring modifications after instantiation. This is particularly useful for assigning multiple options at once, e.g.