added tracker object methods#6
Merged
andrew merged 2 commits intosplitrb:masterfrom Jul 23, 2013
jpoday:add-tracker-object-methods
Merged
added tracker object methods#6andrew merged 2 commits intosplitrb:masterfrom jpoday:add-tracker-object-methods
andrew merged 2 commits intosplitrb:masterfrom
jpoday:add-tracker-object-methods
Conversation
|
Is this project still active/compatible? Just started looking into it, and wondered too if "_trackPageLoadTime()" needs to be removed or if the js needs to otherwise be updated. |
Member
|
Sorry, not sure how this one slipped through the cracks of my inbox, will merge it in now. Thanks! |
|
Cool, thanks man :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Andrew,
I had a need for some additional tracker methods, and I saw you had a note that said you needed more options. I added this functionality. The input uses a hash of method names with corresponding values. All three types of object arguments are supported (String, Boolean, and no arguments). I also updated the Readme with the new functionality.
I added a test, which passes, but I was getting an failure on the custom variables test as it was checked out. It can't seem to find the session variable in the tests. I chalked this up to a test issue and I didn't resolve it. I'm a bit of a noob and it would probably take me forever to figure out.
I also removed the "_trackPageLoadTime()" from the generated javascript, as Google says the method is deprecated.
This is only my second pull request ever, so feel free to tear me up. Like I said, I'm a bit of a noob.
Thanks,
-Joe