Skip to content

Fixing call to get Split definitions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HJewkes merged 3 commits into from
May 4, 2021
Merged

Fixing call to get Split definitions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d0430
Fixing call to get Split definitions
HJewkes May 4, 2021
8fac363
Update logging
HJewkes May 4, 2021
dbea56c
Fixing multi-variant creation
HJewkes May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

setup(
name='splitcli',
version='0.0.9',
version='0.0.10',
description='Use Split.io from the command line',
long_description=long_description,
long_description_content_type='text/markdown',
Expand Down
1 change: 0 additions & 1 deletion splitcli/accounts/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def load_user():
try:
with open(config.config_file, 'r') as f:
dictionary = json.load(f)
print(dictionary)
return User(dictionary["adminapi"], dictionary["orgID"], dictionary["userID"], dictionary["firstname"], dictionary["lastname"], dictionary["email"])
except:
return None
Expand Down
1 change: 0 additions & 1 deletion splitcli/experiment/batch_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def track(self, key, traffic_type, event_type, value, properties):
while not success:
success = self.split_client.track(key, traffic_type, event_type, value, properties)
if not success:
print(key, traffic_type, event_type, value, properties)
time.sleep(.1)

def destroy(self):
Expand Down
4 changes: 2 additions & 2 deletions splitcli/splitio_selectors/definition_selectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

def manage_definition(workspace, split, environment):
while True:
definition = get_definition_operator(workspace["name"], environment["name"], split["name"])
definition = get_definition_operator(workspace["id"], environment["name"], split["name"])
if definition == None:
(treatments, baseline) = select_treatments()
create_definition_operator(workspace["id"], environment["name"], split["name"], treatments, baseline)
Expand Down Expand Up @@ -41,7 +41,7 @@ def select_treatments():

def input_treatments():
treatments = menu.input_list("Add treatment name", treatments_validator)
baseline,_ = menu.select("Select baseline treatment", treatments)
baseline = menu.select("Select baseline treatment", treatments)
return (treatments, baseline)

def treatments_validator(treatments):
Expand Down
1 change: 0 additions & 1 deletion splitcli/splitio_selectors/segment_selectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ def show_keys(segment_name, environment):
page = 0
while True:
keys = segments_api.get_segment_keys(segment_name, environment["name"], page)
print(keys)

def add_keys(segment_name, environment):
pass
Expand Down
2 changes: 1 addition & 1 deletion splitcli/splitio_selectors/split_selectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def manage_split(workspace, split):

options = []
for environment in environments:
definition = definition_selectors.get_definition_operator(workspace, split, environment)
definition = definition_selectors.get_definition_operator(workspace["id"], environment["name"], split["name"])
option = environment
if definition == None:
option["option_name"] = "Create in " + option["name"]
Expand Down