Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions splitio/engine/cache/lru.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ def test_and_set(self, key, value):
to_return = node.value if node else None
if node is None:
node = SimpleLruCache._Node(key, value, None, None)
else:
node.value = value
node = self._bubble_up(node)
self._data[key] = node
self._rollover()
Expand Down
42 changes: 42 additions & 0 deletions tests/engine/cache/test_lru_updates.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
"""Regression coverage for replacing cached impression timestamps."""
from splitio.engine.cache.lru import SimpleLruCache
from splitio.engine.impressions.manager import Observer
from splitio.models.impressions import Impression


class LruUpdateTests(object):
def test_repeated_updates_return_latest_value(self):
cache = SimpleLruCache(2)
assert cache.test_and_set('key', 1) is None
assert cache.test_and_set('key', 2) == 1
assert cache.test_and_set('key', 3) == 2

def test_update_promotes_and_replaces_lru(self):
cache = SimpleLruCache(2)
cache.test_and_set('a', 1)
cache.test_and_set('b', 2)
assert cache.test_and_set('a', 3) == 1
cache.test_and_set('c', 4)
assert cache.test_and_set('a', 5) == 3
assert cache.test_and_set('b', 6) is None

def test_observer_reports_immediately_previous_time(self):
observer = Observer(2)
def impression(timestamp):
return Impression('key', 'flag', 'on', 'rule', 1, None, timestamp, None, None)
assert observer.test_and_set(impression(100)).previous_time is None
assert observer.test_and_set(impression(200)).previous_time == 100
assert observer.test_and_set(impression(300)).previous_time == 200

def test_optimized_strategy_deduplicates_after_hour_boundary(self, mocker):
from splitio.engine.impressions.strategies import StrategyOptimizedMode
mocker.patch('splitio.engine.impressions.strategies.utctime_ms', return_value=3600200)
strategy = StrategyOptimizedMode()
def impression(timestamp):
return Impression('key', 'flag', 'on', 'rule', 1, None, timestamp, None, None)
stored, _, _, _ = strategy.process_impressions([(impression(1000), None)])
assert len(stored) == 1
stored, _, _, _ = strategy.process_impressions([(impression(3600100), None)])
assert len(stored) == 1
stored, _, _, _ = strategy.process_impressions([(impression(3600200), None)])
assert stored == []
16 changes: 8 additions & 8 deletions tests/engine/test_impressions.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,13 @@ def test_standalone_optimized(self, mocker):
(ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None),
(ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None)
])
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)]
assert deduped == 0
assert for_unique_keys_tracker == []

assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen
assert for_counter == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
assert for_counter == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)]

# Test counting only from the second impression
Expand Down Expand Up @@ -221,7 +221,7 @@ def test_standalone_debug(self, mocker):
(ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None),
(ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None)
])
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)]
assert for_counter == []
assert for_unique_keys_tracker == []
Expand Down Expand Up @@ -340,17 +340,17 @@ def test_standalone_optimized_listener(self, mocker):
(ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None),
(ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None)
])
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)]
assert deduped == 0
assert listen == [
(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), None),
(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), None),
(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None), None),
]
assert for_unique_keys_tracker == []
assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen
assert for_counter == [
Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)
]

Expand Down Expand Up @@ -425,10 +425,10 @@ def test_standalone_debug_listener(self, mocker):
(ImpressionDecorated(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, None, None), False), None),
(ImpressionDecorated(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, None, None), False), None)
])
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None),
assert imps == [Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None),
Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None)]
assert listen == [
(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-3, None), None),
(Impression('k1', 'f1', 'on', 'l1', 123, None, utc_now-1, old_utc-2, None), None),
(Impression('k2', 'f1', 'on', 'l1', 123, None, utc_now-2, old_utc-1, None), None)
]
assert len(manager._strategy._observer._cache._data) == 3 # distinct impressions seen
Expand Down