Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: splitio/javascript-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: splitio/javascript-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: configs-poc
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 30 files changed
  • 1 contributor

Commits on Nov 12, 2026

  1. issue-8 · Co-export ConfigsClient from the flags SDK with a Node/brow…

    …ser split
    
    Issue: 8-co-export-configsclient-from-the-flags-s.md
    Refs issue-8
    
    ## Summary
    - `src/configs/{package.json,node.js,browser.js}`: node re-exports `ConfigsClient` from `@splitsoftware/configs`; browser exports a stub that throws "ConfigsClient is Node-only" and does not import configs (no node-fetch in browser bundles).
    - `src/index.js` exports `ConfigsClient`.
    - `tsconfig.json`: `skipLibCheck` (configs .d.ts references SplitIO types absent from this compilation; otherwise `build:npm` fails).
    - Dependency is a local tarball (`file:/tmp/splitsoftware-configs-1.0.0-beta4.tgz`) for POC only; must become a registry version before publishing.
    - Node ESM works through `main` (cjs): `import { ConfigsClient } from '@splitsoftware/splitio'` resolves cjs/index.js, which requires configs' CJS build. configs' esm/ (extensionless imports) is never loaded by Node.
    
    ## Model usage
    Implementation done directly by the coordinator on sonnet (global.anthropic.claude-sonnet-5-5); no separate implementer or reviewer dispatched (small change).
    
    ## Learnings
    tsc with allowJs type-checks a dependency's .d.ts on import; skipLibCheck needed. Node ESM reaches the CJS main, so cjs-module-lexer sees the named re-exports.
    gthea committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    2b39c3e View commit details
    Browse the repository at this point in the history
  2. issue-11 · sdkKey helper, aggregated whenReady and hand-written types

    Adds createConfigsClient(factory, options) (sdkKey from the factory, logLevel and requestOptions inherited unless overridden) and an aggregated whenReady(flagsClient, configsClient) that resolves {flags, configs} and rejects naming the client that timed out. Hand-written types in types/configs.d.ts (never imports configs' own d.ts), exposed from types/index.d.ts and types/server/index.d.ts, checked in ts-tests/configs.ts with TypeScript 4.4.4.
    
    Types survive without skipLibCheck: yes for the new files (strict compile clean). The root tsc with skipLibCheck false still errors only inside configs' own d.ts (JsonObject/Target missing from commons 2.13.1).
    
    Plan: single task, helpers with injected client for unit tests, then types and ts-tests.
    
    Model usage: coordinator sonnet; implementer sonnet (label model:sonnet); reviewer sonnet (PASS, 3 minor survivors deferred: no test pins the './' browser import in helpers.js, the sdkKey?: never clause, Target.key required).
    
    Learnings: lint forbids array destructuring in src; configs' d.ts needs a newer commons than 2.13.1; reviewer mutation of a browser import needs a browser build test (not added).
    
    Refs issue-11
    Issue: 11-sdkkey-helper-aggregated-whenready-and-h.md
    gthea committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    65b68d5 View commit details
    Browse the repository at this point in the history
  3. issue-15 · Sample app, size limit and forbidden-module check

    Issue: 15-sample-app-size-limit-and-forbidden-modu.md
    Refs issue-15
    
    ## Summary
    - scripts/check-forbidden-modules.js (npm run check:umd): fails when the UMD output imports node-fetch, https or process; test + bad/good fixtures (npm run test-forbidden-modules).
    - sample/: local-only Node app (CJS + ESM, run.sh) installing an npm pack tarball of this branch plus the local configs tarball; evaluates a localhost-mode flag and a config against a local stub endpoint. Tarballs and node_modules are gitignored.
    - UMD build: split-dev-11.12.1.min.js 136165 B, under the 138249 B (135 KiB) limit (webpack hints: error).
    
    ## Test plan
    check, test-ts-decls, test-node-unit (82), test-node-e2e-offline (186), test-browser-unit (6, Chrome headless), test-forbidden-modules (9).
    
    ## Model usage
    No implementer dispatched (small scripts); coordinator Sonnet 5.5.
    
    ## Learnings
    BSD sed needs `-i ''`; localhost-mode Node needs a yaml file path, getTreatment is (key, flag). Bare `process` guarded by typeof is legitimate in UMD, so the check matches imports, not the word.
    
    AI-Session-Id: 312bded0-bba5-4bee-8811-2e87f163ad95
    AI-Tool: claude-code
    AI-Model: unknown
    gthea committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    5f078f0 View commit details
    Browse the repository at this point in the history
  4. POC: depend on public @splitsoftware/configs 1.0.0-beta4, add sample …

    …README
    
    Replace the file: tarball dependency with the registry version 1.0.0-beta4
    (public npm, beta tag), so a clone installs without local files. run.sh no
    longer takes a configs tarball. Sample, UMD forbidden-module check and size
    (136165 B) verified against the registry package.
    gthea committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    f14f067 View commit details
    Browse the repository at this point in the history
  5. issue-28 · Harden Track A tests flagged by the retroactive reviews

    Issue: 28-test-hardening.md
    Refs issue-28
    
    ## Plan
    Test-only. Kill survivors from retro reviews of issues 8 and 15, each proven red by re-applying the mutation.
    
    ## Changes
    - browserStub.spec.js: `browser` field resolves to existing browser.js; stub has no @splitsoftware/configs or node-fetch import; error is exactly Error.
    - check-forbidden-modules.test.js: CLI directory expansion (.js collected, non-.js ignored, empty dir exits 2).
    - package.json scripts: `check` now runs test-forbidden-modules; new `check:forbidden` and `check:bundle` (build-umd + check:umd).
    
    ## Rulings
    Ruling: check:umd needs a prior UMD build, so the default gate does not run it; `check` runs the forbidden-module unit tests (no build), and `npm run check:bundle` builds then checks the bundle. The profile gate text is unchanged; add check:bundle there if wanted.
    
    ## Deferred minors
    bad.mjs/.cjs fixture for the ignored-dir test; no test of script wiring.
    
    ## Learnings
    None new.
    
    ## Model usage
    Implementer sonnet, reviewer sonnet (28-review-1.md), coordinator sonnet.
    gthea committed Nov 12, 2026
    Configuration menu
    Copy the full SHA
    493dfc1 View commit details
    Browse the repository at this point in the history
Loading