feat(orca): support additional metric tags on stage execution context - #8005
Open
apoorvmahajandd wants to merge 4 commits into
Open
feat(orca): support additional metric tags on stage execution context#8005apoorvmahajandd wants to merge 4 commits into
apoorvmahajandd wants to merge 4 commits into
Conversation
Extract an optional additionalMetricTags map from the stage context during StageExecutionImpl construction, mirroring how other reserved context keys (e.g. requisiteStageRefIds) are already extracted. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jasonmcintosh
approved these changes
Sep 12, 2026
Member
|
I'll note ONE Risk: It's user input being added to a system that sends data to a remote system. I'm still in general in FAVOR of this... but I could also see this used to make an remote type attack with ... bad label inputs kinda things. I'd think this is a LOW possibility overall, why I'm approving it, just a "caution" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract an optional additionalMetricTags map from the stage context during StageExecutionImpl construction, mirroring how other reserved context keys (e.g. requisiteStageRefIds) are already extracted.
We can now inject custom metric tags from stages into existing stage metrics
Testing
after adding this:
to the stage context
🤖 Generated with Claude Code