allow mathjax3_config to point to a JS file #14025
Open
+45
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randolf-scholz
commented
Nov 4, 2025
randolf-scholz
commented
Nov 4, 2025
| if not config_filepath.exists(): | ||
| msg = f'mathjax3_config file not found: {config_filepath!s}' | ||
| raise ExtensionError(msg) | ||
| if not config_filepath.is_file() or config_filepath.suffix != '.js': |
There was a problem hiding this comment.
Are there other extension than .js to consider? I am not familiar with javascript
randolf-scholz
commented
Nov 4, 2025
Comment on lines
+379
to
+395
| @pytest.mark.sphinx( | ||
| 'html', | ||
| testroot='ext-math', | ||
| confoverrides={ | ||
| 'extensions': ['sphinx.ext.mathjax'], | ||
| 'mathjax3_config': '_static/custom_mathjax_config.js', | ||
| }, | ||
| ) | ||
| def test_mathjax3_js_config(app: SphinxTestApp) -> None: | ||
| app.build(force_all=True) | ||
|
|
||
| content = (app.outdir / 'index.html').read_text(encoding='utf8') | ||
| assert MATHJAX_URL in content | ||
| assert '<script defer="defer" src="%s">' % MATHJAX_URL in content | ||
| assert '<script>window.MathJax = {"extensions": ["tex2jax.js"]}</script>' in content | ||
|
|
||
|
|
There was a problem hiding this comment.
I just duplicated the test above and moved the config to _static/custom_mathjax_config.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14023
Note: git was telling me that these two files were modified, I'm not sure what's going on: