-
Notifications
You must be signed in to change notification settings - Fork 470
Improved hypervisor detection #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
``` opt_batch_format="text" ``` replaced by ``` opt_batch_format='text' ``` ```nrpe_vuln='"" ``` replaced by ``` nrpe_vuln='' ``` , as used by other parse options Redundant ``` ! -z ``` replaced by ``` -n ```, as used elsewhere Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Tests for presence of hypervisor flag in /proc/cpuino Tests for evidence of hypervisor in dmesg Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Signed-off-by: Rob Gill <rrobgill@protonmail.com>
…ailable (prevents invalid number error when evaluating [ "$l1d_mode" -ge 1 ]) Signed-off-by: Rob Gill <rrobgill@protonmail.com>
Update processor names of atom 6 family processors to align with those from kernel as of October 2018. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/x86/include/asm/intel-family.h?id=f2c4db1bd80720cd8cb2a5aa220d9bc9f374f04e Update list of known immune processors from https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/kernel/cpu/common.c?id=f2c4db1bd80720cd8cb2a5aa220d9bc9f374f04e
Another instance of unset l1d_mode causing error "./spectre-meltdown-checker.sh: 3867: [: Illegal number:"
L1tf mitigation and impact details from https://www.kernel.org/doc/html/latest/admin-guide/l1tf.html and https://blogs.oracle.com/oraclesecurity/intel-l1tf
|
Thanks for your work, and sorry for the time it took me to check your PR! On the "has_vmm" code however, your version of the code (which is way less dumb than the |
|
Yes, effectively reversing the detection assuming bare metal if not detected as inside the vm. |
|
Indeed, so we make the assumption that if we're on bare metal, we possibly are actually hosting an hypervisor that might host VMs. This is probably reasonable, and the behavior can still be overridden through the comand-line, if we are on bare metal and we know we'll never run VMs on it. |
Tests for presence of hypervisor flag in /proc/cpuino if available and tests for evidence of hypervisor in dmesg. (Rather than relying on output of ps).
Also fix unset $l1d_mode causing error & typos.
Update processor names of atom 6 family processors to align with those from kernel as of October 2018.