Fix device handling for MPS#3055
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #3054 by ensuring device_type is always set when initializing training (Brain) and inference (Pretrained) interfaces, so non-CPU/non-CUDA device strings (e.g., "mps") don’t trigger AttributeError during subsequent device checks / autocast setup.
Changes:
- Add a fallback branch in
Brain.__init__to setself.device_typefor non-CPU/non-CUDA devices. - Add a fallback branch in
Pretrained.__init__to setself.device_typefor non-CPU/non-CUDA devices.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| speechbrain/inference/interfaces.py | Sets device_type for non-CPU/non-CUDA devices during inference interface initialization. |
| speechbrain/core.py | Sets device_type for non-CPU/non-CUDA devices during core training interface initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will set
device_typefor all devices, preventing subsequent checks from crashingFixes #3054
PR review
Reviewer checklist