Skip to content

fix bug in reverberate with rescale_amp#2871

Merged
pplantinga merged 4 commits intospeechbrain:developfrom
ofiryaish:fix-rescale-amplitude
May 21, 2025
Merged

fix bug in reverberate with rescale_amp#2871
pplantinga merged 4 commits intospeechbrain:developfrom
ofiryaish:fix-rescale-amplitude

Conversation

@ofiryaish
Copy link
Contributor

@ofiryaish ofiryaish commented Mar 31, 2025 •
edited
Loading

What does this PR do?

Fixes #2870

  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Adel-Moumen Adel-Moumen requested a review from pplantinga May 21, 2025 12:15
pplantinga
pplantinga approved these changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pplantinga pplantinga merged commit fe9178c into speechbrain:develop May 21, 2025
1 check passed
pplantinga added a commit that referenced this pull request May 22, 2025
@pplantinga
Fix Black error introduced in #2871
d10acec
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@ofiryaish @TParcollet @pplantinga
fix bug in reverberate with rescale_amp (speechbrain#2871)
843edc3 
Co-authored-by: Parcollet Titouan <parcollet.titouan@gmail.com>
pplantinga added a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@pplantinga
Fix Black error introduced in speechbrain#2871
ba688f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pplantinga pplantinga pplantinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support no rescale amplitude in processing.signal_processing.reverberate

3 participants

@ofiryaish @pplantinga @TParcollet