Add pydoclint#2469
Merged
Merged
Conversation
…ion about the meaning in our use case
Adel-Moumen
approved these changes
Mar 26, 2024
Adel-Moumen
left a comment
Adel-Moumen
left a comment
Collaborator
There was a problem hiding this comment.
Hello @pplantinga,
Thanks for this PR! This is a really nice addition to SB. I went through the first 130 files (and now it start to be a bit painful since I need to "load diff" each file in the GitHub interface), but everything looks good so far.
I only left 1-2 comments but overall this is great and we should move on with this PR. Thanks again.
Collaborator
|
One thing that comes into my mind is that we should also make sure to update https://github.com/speechbrain/benchmarks as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pydoclint extension to flake8 for docstring linting.