Skip to content

Fix use of huggingface_hub.cached_download#1458

Merged
mravanelli merged 5 commits into
speechbrain:developfrom
SolomidHero:patch-1
Jun 21, 2022
Merged

Fix use of huggingface_hub.cached_download#1458
mravanelli merged 5 commits into
speechbrain:developfrom
SolomidHero:patch-1

Conversation

@SolomidHero

@SolomidHero SolomidHero commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

issue #1459

@SolomidHero SolomidHero mentioned this pull request Jun 21, 2022
Closed
@mravanelli mravanelli requested a review from Gastron June 21, 2022 17:02
@mravanelli

mravanelli commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

It looks like this is due to an interface change in the latest version of HuggingFace Hub. We can fix it in the development branch, but people using the main branch will see this error. Also, it seems your fix doesn't solve the problem:

  File "<stdin>", line 1, in <module>
  File "/network/scratch/r/ravanelm/speechbrain/speechbrain/pretrained/interfaces.py", line 338, in from_hparams
    pymodule_local_path = fetch(
  File "/network/scratch/r/ravanelm/speechbrain/speechbrain/pretrained/fetching.py", line 118, in fetch
    if e.response.status_code == 404:
AttributeError: 'NoneType' object has no attribute 'status_code'

julien-c
julien-c reviewed Jun 21, 2022
View reviewed changes
Comment thread speechbrain/pretrained/fetching.py Outdated
@mravanelli @julien-c
Update speechbrain/pretrained/fetching.py
1046a66 
Co-authored-by: Julien Chaumond <julien@huggingface.co>
julien-c
julien-c reviewed Jun 21, 2022
View reviewed changes
Comment thread speechbrain/pretrained/fetching.py Outdated
@@ -113,7 +113,7 @@ def fetch(
logger.info(MSG)
url = huggingface_hub.hf_hub_url(source, filename)

@julien-c julien-c Jun 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to also remove that line if possible :)

@SolomidHero

SolomidHero commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

Should we also update requirements:

speechbrain/requirements.txt

Line 2 in 786ec32

huggingface_hub>=0.0.6

to the moment this hf_hub_download function was proposed (0.0.19 as latest patch version)

@TParcollet

TParcollet commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator

I hope it won't break other things to do this ...

@mravanelli

mravanelli commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator

Thank you @SolomidHero @julien-c for the help. I think we can merge it!

@mravanelli mravanelli merged commit 34be08f into speechbrain:develop Jun 21, 2022
@pplantinga pplantinga mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gastron Gastron Awaiting requested review from Gastron

1 more reviewer

@julien-c julien-c julien-c left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

important

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SolomidHero @mravanelli @TParcollet @julien-c