fix(zero): share Fly creds + OCI app with assistant runtime in zero:fly#2876
fix(zero): share Fly creds + OCI app with assistant runtime in zero:fly#2876danielkov wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41c6578649
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func (n *noopRuntimeBackend) Ensure(_ context.Context, _ assistantRuntimeRecord) (RuntimeBackendEnsureResult, error) { | ||
| return RuntimeBackendEnsureResult{}, errNoopRuntimeNotConfigured |
There was a problem hiding this comment.
When local dev runs with the new noop provider and any assistant is invoked, ServiceCore.ProcessThreadEvents treats an Ensure error as a transient setup failure: it marks the runtime failed, returns RetryAdmission, and the thread workflow re-signals admission after the 30s backoff. Since noop.Ensure always returns this same error before any event is claimed, the event never reaches the terminal error path and stays pending in an endless retry cycle instead of surfacing the promised not-configured error. Either let noop Ensure succeed and fail at RunTurn, or classify this error as terminal before returning RetryAdmission.
Useful? React with 👍 / 👎.
🚀 Preview Environment (PR #2876)Preview URL: https://pr-2876.dev.getgram.ai
Gram Preview Bot |
zero:fly already collected Fly creds for Gram Functions but never wrote the
assistant-runtime equivalents, so a fresh checkout running ./zero failed
mise start:server's FlyRuntimeConfig.Validate() on missing
--assistant-runtime-flyio-{api-token,org} and --assistant-runtime-oci-image.
The functions runner Fly app already covers our dev needs — assistants push
under a separate :dev tag — so reuse the same token, org, region, and OCI
app for the assistant runtime and drop the dedicated assistant-app prompt.
Closes AGE-2370
danielkov
force-pushed
the
daniel/age-2370-restore-dev-bootable-assistant-runtime-default
branch
from
41c6578 to
0b487b7
Compare
danielkov
changed the title
3 participants
Summary
zero:flyalready prompted for Fly credentials but never wrote the assistant-runtime equivalents, somise start:serverafter a fresh./zerofailedFlyRuntimeConfig.Validate().:devtag, so a second Fly app isn't required for local dev.GRAM_ASSISTANT_RUNTIME_FLYIO_{API_TOKEN,ORG,REGION}alongside the existingGRAM_ASSISTANT_RUNTIME_OCI_IMAGE+_IMAGE_VERSION.Closes AGE-2370.
✻ Clauded...