Add support for templated keys for various operations#162
Open
xroche wants to merge 1 commit intosparsehash:masterfrom
Open
Add support for templated keys for various operations#162xroche wants to merge 1 commit intosparsehash:masterfrom
xroche wants to merge 1 commit intosparsehash:masterfrom
Conversation
xroche
force-pushed
the
feat/templated-key-for-find-count-equal_range
branch
from
de0d995 to
aff25f9
Compare
This includes `find`, `count`, `equal_range` The rationale is that `HashFcn` and `EqualKey` passed during type construction may be tuned to support more types compared by the fixed type `key_type`. * `HashFcn` would typically implement additional `size_t operator()(const T& key) const` member(s) * `EqualKey` would typically implement additional `bool operator()(const T& other, const key_type& value) const` member(s)
xroche
force-pushed
the
feat/templated-key-for-find-count-equal_range
branch
from
aff25f9 to
30a408e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes
find,count,equal_rangeThe rationale is that
HashFcnandEqualKeypassed during typeconstruction may be tuned to support more types compared by the fixed
type
key_type.HashFcnwould typically implement additionalsize_t operator()(const T& key) constmember(s)EqualKeywould typically implement additionalbool operator()(const T& other, const key_type& value) constmember(s)Code tested and validated in our codebase (https://github.com/algolia)