Repository navigation
Conversation
|
1 potential issue found:
↑ Select any checkbox above to have Indent auto-fix the issue 1 issue already resolved
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Found issues (1)
Full resultsIndent Review Agent
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
| Layer / File(s) | Summary |
|---|---|
Document unpublished response behavior content/(serve)/urls.mdx, content/(reference)/limits.mdx |
The serving documentation describes a 404 response for unrouted hostnames and Spaces that have never published. The reference documentation describes the strictest-safety response as 404 and specifies the undeployed response header. Both document the unpublished response body; the serving documentation also retains the Cache-Control: no-store header. The reference documentation clarifies that legal-removal and no-longer-available pages are customizable. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Suggested reviewers: alexanderaidun-a8c
Merge Risk: 
42d63
-
No actionable defect is established in the supplied documentation change.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: documenting 404 responses for unpublished hosts. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![indent[bot]](https://avatars.githubusercontent.com/in/4161513?s=60&v=4){kind=small}
| ## Hostnames that do not serve | ||
|
|
||
| A request to a hostname Spacefast does not route, or to a Space that has never published, answers `503` with `Cache-Control: no-store` and the body `This space hasn't been published yet.` It is deliberately not a 404, so a monitoring check can tell "nothing here yet" apart from "this page is missing". | ||
| A request to a hostname Spacefast does not route, or to a Space that has never published, answers `404` with `Cache-Control: no-store` and the body `This space hasn't been published yet.` The response includes `X-Spacefast-Undeployed: 1`. Use that header or the body to tell "nothing here yet" apart from a missing page on a published site. |
There was a problem hiding this comment.
🟡 Bug · Docs describe 404 behavior that production doesn't ship yet
Production runtime on monorepo main still returns 503 for unpublished hosts (_stattic_undeployed_action in runtime/engine/runtime/serve.php) and for the strictest-safety tombstone (runtime/engine/shared/artifacts.php), and nothing sets X-Spacefast-Undeployed. The change to 404 plus the header is spacefast/monorepo#4402, still open. If this merges first, monitors keyed on the header or a 404 will misread real 503 responses. Merge only after #4402 is deployed, or list it as a dependency in the description.
The same applies to the limits.mdx table row and paragraph.
Found by Indent Review Agent
|
@indent please review this PR and commit fixes for them as well |
|
Review done, one fix pushed in 0c400e0.
|
Unpublished hostnames and strictest-safety removals return 404 with
X-Spacefast-Undeployed: 1. Explain how the marker or response body distinguishes these responses from a missing page on a published site. Coordinate publication with the runtime behavior change.Validation: generated-reference verification, strict typecheck, link validation, full build, docs tests, composed-site audit, route verification, public-safety verification, and prose verification.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit
404responses, distinguishable from missing pages on published sites by a response header. The response body and cache behavior remain unchanged.