Skip to content

enhance the display url for all addresses 0.0.0.0 while using httpd#2

Open
brendanator wants to merge 1 commit intobase-sha/761018dc5954b848d184a019ffabcdc917657cebfrom
head-sha/fdc52af263013d3af82974990c94b6bb605b4fd6/2024-04-09T11-53-36/50b6e4
Open

enhance the display url for all addresses 0.0.0.0 while using httpd#2
brendanator wants to merge 1 commit intobase-sha/761018dc5954b848d184a019ffabcdc917657cebfrom
head-sha/fdc52af263013d3af82974990c94b6bb605b4fd6/2024-04-09T11-53-36/50b6e4

Conversation

@brendanator
Copy link

The original log ## Open your webbrowser at the URL: http://localhost:42525 is ambiguous when I already set addr to 0.0.0.0. It looks like the server runing only on localhost.
After merge this PR, when addr isn't 0.0.0.0, the log will show as

## Open your webbrowser at the URL: http://localhost:42525

and show as the following when addr is 0.0.0.0

## Running on all addresses (0.0.0.0)
## Open your webbrowser at the URL: http://192.168.33.111:42525

@brendanator
Copy link
Author

This is a benchmark review for experiment review_of_100_reviews_20240409.
Run ID: review_of_100_reviews_20240409/benchmark_2024-04-09T11-53-25_v1-16-0-95-g65fefaeef-dirty.

This pull request was cloned from https://github.com/tpaviot/pythonocc-core/pull/1311. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants