Debug parent symbol

varungandhi-src · varungandhi-src · commit fe761adae285 · 2023-08-22T10:33:02.000+08:00
diff --git a/packages/pyright-scip/src/lsif-typescript/Descriptor.ts b/packages/pyright-scip/src/lsif-typescript/Descriptor.ts
@@ -6,9 +6,9 @@ type Suffix = scip.Descriptor.Suffix;
 const Suffix = scip.Descriptor.Suffix;
 
 export function packageDescriptor(name: string): Descriptor {
-    if (name === '') {
-        throw new Error('Package name cannot be empty');
-    }
+    // if (name === '') {
+    //     throw new Error('Package name cannot be empty');
+    // }
     return new Descriptor({ name, suffix: Suffix.Namespace });
 }
 
diff --git a/packages/pyright-scip/src/symbols.ts b/packages/pyright-scip/src/symbols.ts
@@ -27,13 +27,13 @@ export function makeModule(pythonPackage: PythonPackage, moduleName: string): Sc
     if (ns) {
         moduleName = ns + '.' + moduleName;
     }
-    if (moduleName === '') {
-        throw new Error(
-            `Module name is empty namespace = ${ns}, pkgname = ${pythonPackage.name}, map = ${JSON.stringify(
-                Object.fromEntries(namespaces)
-            )}`
-        );
-    }
+    // if (moduleName === '') {
+    //     throw new Error(
+    //         `Module name is empty namespace = ${ns}, pkgname = ${pythonPackage.name}, map = ${JSON.stringify(
+    //             Object.fromEntries(namespaces)
+    //         )}`
+    //     );
+    // }
 
     return ScipSymbol.global(makePackage(pythonPackage), packageDescriptor(moduleName));
 }
diff --git a/packages/pyright-scip/src/treeVisitor.ts b/packages/pyright-scip/src/treeVisitor.ts
@@ -1091,7 +1091,12 @@ export class TreeVisitor extends ParseTreeWalker {
                 return Symbols.makeParameter(this.getScipSymbol(node.parent!), node.name.value);
             }
             case ParseNodeType.Class: {
-                return Symbols.makeType(this.getScipSymbol(node.parent!), (node as ClassNode).name.value);
+                const x = (node as ClassNode).name.value;
+                const parentSym = this.getScipSymbol(node.parent!);
+                if (x.indexOf('SuchNestedMuchWow') !== -1) {
+                    console.log(`parentSym = ${parentSym.value} for SuchNestedMuchWow`);
+                }
+                return Symbols.makeType(parentSym, x);
             }
             case ParseNodeType.Function: {
                 let cls = ParseTreeUtils.getEnclosingClass(node, false);

Original file line number	Diff line number	Diff line change
`@@ -1091,7 +1091,12 @@ export class TreeVisitor extends ParseTreeWalker {`
`1091`	`1091`	`return Symbols.makeParameter(this.getScipSymbol(node.parent!), node.name.value);`
`1092`	`1092`	`}`
`1093`	`1093`	`case ParseNodeType.Class: {`
`1094`		`- return Symbols.makeType(this.getScipSymbol(node.parent!), (node as ClassNode).name.value);`
	`1094`	`+ const x = (node as ClassNode).name.value;`
	`1095`	`+ const parentSym = this.getScipSymbol(node.parent!);`
	`1096`	`+ if (x.indexOf('SuchNestedMuchWow') !== -1) {`
	`1097`	+ console.log(`parentSym = ${parentSym.value} for SuchNestedMuchWow`);
	`1098`	`+ }`
	`1099`	`+ return Symbols.makeType(parentSym, x);`
`1095`	`1100`	`}`
`1096`	`1101`	`case ParseNodeType.Function: {`
`1097`	`1102`	`let cls = ParseTreeUtils.getEnclosingClass(node, false);`