Add handling added/deleted files in diff#50
Merged
keegancsmith merged 3 commits intosourcegraph:masterfrom Aug 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 28.31% 29.48% +1.17%
==========================================
Files 5 5
Lines 1155 1177 +22
==========================================
+ Hits 327 347 +20
- Misses 783 784 +1
- Partials 45 46 +1
Continue to review full report at Codecov.
|
schachmat
reviewed
Aug 10, 2020
schachmat
left a comment
There was a problem hiding this comment.
Thanks. Added some comments. Final decision on how to implement this is with the repo owners of course.
Member
keegancsmith
left a comment
There was a problem hiding this comment.
Will want @eseliger to take a look as well.
Member
|
BTW thank you so much for the great pull request! |
keegancsmith
approved these changes
Aug 18, 2020
sofiia-tesliuk
added a commit
to sofiia-tesliuk/go-diff
that referenced
this pull request
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #49
closes #49
There are some changes from planned implementation:
nilOrigNamefield.[2].OrigName: "source_b/file_3.txtand[2].NewName: ""will be relevant.Because in case diff file only contains messages about added/deleted files, it is impossible to determine which of the sources is the original one.
Then for this file example, the output below for ReadAllFiles() would be expected.
my_diff.txt