diff: support renamed, updated binary file#38
Merged
keegancsmith merged 1 commit intosourcegraph:masterfrom Aug 19, 2020
Merged
diff: support renamed, updated binary file#38keegancsmith merged 1 commit intosourcegraph:masterfrom
keegancsmith merged 1 commit intosourcegraph:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 29.48% 27.24% -2.25%
==========================================
Files 5 5
Lines 1177 1138 -39
==========================================
- Hits 347 310 -37
Misses 784 784
+ Partials 46 44 -2
Continue to review full report at Codecov.
|
|
Thanks for the PR! I am not the best to review this code but |
Member
|
@stephen ping :) |
stephen
force-pushed
the
master
branch
2 times, most recently
from
9001611 to
94f220e
Compare
This commit parses a diff with a renamed, updated binary file and adds a test case for it.
Contributor
Author
|
Thanks for the reminder. I removed the .DS_Store and rebased to fix conflicts. I tried to match the changes in f935979 in my new diff. |
Contributor
Author
|
Separately, adding |
keegancsmith
approved these changes
Aug 19, 2020
Member
|
Thanks! |
sofiia-tesliuk
pushed a commit
to sofiia-tesliuk/go-diff
that referenced
this pull request
Aug 25, 2020
This commit parses a diff with a renamed, updated binary file and adds a test case for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit parses a diff with a renamed, updated binary file and adds a test case for it.