Repository navigation
ci/vercel-build-log: Keep big changed-page lists a Slack table - #2161
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
A table over Slack's 10,000 characters fell back to text rows, which Slack split into several replies and unfurled the preview links under. Now the table keeps the pages that fit and counts the rest in a last row, with the pages past the PR comment's own limit. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d43a-2ab9-77c4-9ac4-aeea3b840866 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PR's changed-page table is over Slack's 10,000-character limit for table cells, the build log reply fell back to one line of text per row. Slack then split that text into several replies and unfurled the preview links under it, e.g. the post for #2132 (4 replies) and the one for #2158.
Now the reply stays a table: it keeps the pages that fit, and a last row counts the rest, including the pages past the preview-links comment's own 40-page limit (
…and 18 more in the PR comment).Test plan
Ran
changedPageRows+fileMessageagainst the real preview-links comments:…and 18 more in the PR comment…and 259 more in the PR commentA 6-row table comes out the same as before, and rows from two PRs still fall back to text.