Conversation
coury-clark
approved these changes
Oct 27, 2022
davejrt
added a commit
that referenced
this pull request
Oct 27, 2022
davejrt
added a commit
that referenced
this pull request
Oct 27, 2022
BolajiOlajide
added a commit
that referenced
this pull request
Oct 28, 2022
* upgrade to v4.1.1 * increase timeout, volume permissions (#870) Co-authored-by: Dave Try <davetry@gmail.com>
BolajiOlajide
added a commit
that referenced
this pull request
Oct 28, 2022
* release: sourcegraph@4.1.1 * increase timeout, volume permissions (#870) Co-authored-by: Dave Try <davetry@gmail.com>
paolodedios
added a commit
to paolodedios/sourcegraph-docker
that referenced
this pull request
Oct 28, 2022
…cker into release * 'master' of github.com:sourcegraph/deploy-sourcegraph-docker: increase timeout, volume permissions (sourcegraph#870)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the timeout for containers to start. This is required for customer-replica branches where frontend containers sometimes require more time to start due to database connections.
This also re-adds the volume setup which was previously removed ( I believe in error). This is required to ensure the volumes exist on disk, then the correct permissions to the directories on disk are applied.
Checklist
Test plan
Green tests on this PR