Repository navigation
ci: Run the smoke test VM with gcloud instead of Vagrant - #1488
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
This was referenced Nov 11, 2026
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 11, 2026 22:23
184dce9 to
ebb8e85
Compare
1 task done
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
2 times, most recently
from
November 12, 2026 04:05
ebbd5b6 to
32ddf90
Compare
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 12, 2026 22:27
32ddf90 to
21feebc
Compare
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 12, 2026 22:56
21feebc to
343915f
Compare
marcleblanc2
changed the base branch from
marc/smoke-test-wait-for-health
to
main
November 13, 2026 04:58
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 13, 2026 04:58
343915f to
3e971cd
Compare
marcleblanc2
changed the base branch from
main
to
marc/ci-check-compose-shell-jaeger-executor
November 13, 2026 04:58
marcleblanc2
marked this pull request as ready for review
November 13, 2026 05:37
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 05:40
stacked auto-merge was automatically disabled
November 13, 2026 07:29
Pull Request is not mergeable
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 13, 2026 07:40
3e971cd to
a08f00a
Compare
smoke-test-vm.sh creates the VM with gcloud, copies the repository to it over SSH, runs test/smoke-test.sh and test/executor-smoke-test.sh, and asks GCP to delete the VM without waiting. GCP deletes each VM an hour after it starts, and each job deletes the VMs and disks older jobs left behind. The boot disk is 20 GB. If the VM stops answering SSH while the repository is copied to it, the script retries the copy on the same VM. Amp-Thread-ID: https://ampcode.com/threads/T-01a1c7a5-6b65-723b-980c-b85e1e9008b5 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/smoke-test-vm-gcloud
branch
from
November 13, 2026 07:51
a08f00a to
0610c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Vagrant with a
gcloudscript for the smoke test VM..buildkite/smoke-test-vm.shcreates the VM, copies the repository to it over SSH, runs the same tests, and deletes it..buildkite/vagrant-run.sh,test/Vagrantfile, andtest/servers.yaml.--max-run-duration=1h), so a job which dies cannot leave a VM running. The step times out after 30 minutes./tmp/e2e-builder.json. The Docker Hub password goes to the VM over stdin, and is no longer written to/root/.profile.sshexits with 255. It never creates a second VM, and never retries a test failure.AGENTS.mdfor the new script.Risk: low. CI only. The VM image, machine type, network, and service account are unchanged.
Things to know
gcloud beta, because the agents have gcloud 417, where--max-run-durationis only in the beta track.vagrant. Renaming it is not part of this PR.8.2.x, so that Vagrant can come off the CI agents. It does not apply there alone: it needs ci: Skip the smoke test on branches which only change files it does not read #1484, ci: Make the smoke test wait for health checks, and check more #1487, and ci: Check every Compose file and shell script, and test Jaeger and the executor #1489 first, or a version made by hand.Checklist
Test plan
gcloudVMgcloud,ssh, andcurlcommands, each of these creates one VM, requests one deletion, and removes the key files:Closes FE-584