Repository navigation
ci: Make the smoke test wait for health checks, and check more - #1487
Open
marcleblanc2 wants to merge 2 commits into
Open
marcleblanc2 wants to merge 2 commits into
marcleblanc2 wants to merge 2 commits into
Conversation
This was referenced Nov 11, 2026
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 11, 2026 22:23
7298ea5 to
d198de1
Compare
This was referenced Nov 11, 2026
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 11, 2026 23:46
d198de1 to
3290bd2
Compare
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 12, 2026 22:27
3e0f620 to
0041077
Compare
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 12, 2026 22:56
0041077 to
e9e20ec
Compare
marcleblanc2
changed the base branch from
marc/batch-change-release-tag-retry
to
main
November 13, 2026 04:58
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 13, 2026 04:58
e9e20ec to
b37e6b1
Compare
marcleblanc2
changed the base branch from
main
to
marc/batch-change-release-tag-retry
November 13, 2026 04:58
1 task done
marcleblanc2
marked this pull request as ready for review
November 13, 2026 05:36
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 05:40
stacked auto-merge was automatically disabled
November 13, 2026 07:29
Auto-merge was disabled for another pull request in the stack
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 13, 2026 07:40
b37e6b1 to
3b5b662
Compare
Replaces the 90 second sleep with docker compose up --wait, pulls images in parallel with retries, counts the expected containers from the Compose file, fails if a container restarted, and saves every container's logs on failure. searcher-0 gets a health check start period, like sourcegraph-frontend-internal. Without it, it reports unhealthy while it waits for the frontend, which fails --wait. Amp-Thread-ID: https://ampcode.com/threads/T-01a1c7a5-6b65-723b-980c-b85e1e9008b5 Co-authored-by: Amp <amp@ampcode.com>
precise-code-intel-worker and syntactic-code-intel-worker are not ready until sourcegraph-frontend-internal serves them the site configuration, and that container waits for the migrator. With a 60 second start period, a slow start marks them unhealthy, and `docker compose up --wait` fails. Build 16902 failed that way: precise-code-intel-worker was unhealthy 71 seconds after it started. searcher-0 got the same start period for the same reason. Amp-Thread-ID: https://ampcode.com/threads/T-01a1c7a5-6b65-723b-980c-b85e1e9008b5 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/smoke-test-wait-for-health
branch
from
November 13, 2026 07:51
3b5b662 to
3f6e2ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the smoke test wait for health checks instead of sleeping, and check more. One change reaches customers: three services get a longer health check start period.
Smoke test
docker compose up --wait --wait-timeout 300instead ofsleep 90. It returns once every container is running and healthy, and fails if one reportsunhealthy.docker compose(v2) instead ofdocker-compose(v1).AGENTS.md.What customers will see
searcher-0,precise-code-intel-worker, andsyntactic-code-intel-workergetstart_period: 300son their health checks, the same assourcegraph-frontend-internal.searcher-0had none, and the two workers had 60 seconds.None of the three is ready until
sourcegraph-frontend-internalis, which waits for the migrator. Until then their health checks fail, so they could showunhealthyduring a start, and--waitgives up on the firstunhealthycontainer. With the start period they showstartinguntil their first check passes.Nothing else changes: Docker does not restart an unhealthy container, and no service waits on the health of these three.
Risk: low. One health check setting on three services; the rest is the test.
Checklist
Test plan
--waitfails: build 16853 withcontainer searcher-0 is unhealthy, and build 16905 withcontainer precise-code-intel-worker is unhealthyshellcheck test/smoke-test.shis cleanCloses FE-586