Repository navigation
docker-compose: Add codeinsights-db to db-only-migrate - #1485
Merged
Merged
Conversation
This was referenced Nov 11, 2026
marcleblanc2
force-pushed
the
marc/db-only-migrate-three-databases
branch
from
November 11, 2026 23:45
e1b6797 to
7966f87
Compare
marcleblanc2
added a commit
to sourcegraph/docs
that referenced
this pull request
Nov 12, 2026
sourcegraph/deploy-sourcegraph-docker#1485 adds codeinsights-db to db-only-migrate.docker-compose.yaml, so the docs page does not need to start it separately. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d197-7a9c-71fc-9998-6e55df9c47d0 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/db-only-migrate-three-databases
branch
from
November 12, 2026 22:27
7966f87 to
61ee565
Compare
marcleblanc2
changed the base branch from
marc/skip-smoke-test-on-docs-only
to
main
November 12, 2026 22:27
marcleblanc2
marked this pull request as ready for review
November 12, 2026 22:28
marcleblanc2
changed the title
1 task done
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 01:38
marcleblanc2
force-pushed
the
marc/db-only-migrate-three-databases
branch
from
November 13, 2026 01:41
61ee565 to
d94786e
Compare
marcleblanc2
disabled stacked auto-merge
November 13, 2026 01:41
michaellzc
approved these changes
Nov 13, 2026
The file left out codeinsights-db, which the backup and restore docs dump, and its copies of pgsql and codeintel-db had drifted from docker-compose.yaml. It now extends all three services from that file.
marcleblanc2
force-pushed
the
marc/db-only-migrate-three-databases
branch
from
November 13, 2026 02:06
d94786e to
dd8c812
Compare
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 02:06
marcleblanc2
added a commit
to sourcegraph/docs
that referenced
this pull request
Nov 13, 2026
sourcegraph/deploy-sourcegraph-docker#1485 adds codeinsights-db to db-only-migrate.docker-compose.yaml, so the docs page does not need to start it separately. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d197-7a9c-71fc-9998-6e55df9c47d0 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
added a commit
to sourcegraph/docs
that referenced
this pull request
Nov 13, 2026
## Problems - The database restore commands passed `-v ERROR_ON_STOP=1` to `psql`, a typo for `ON_ERROR_STOP`, so restores hid their errors and exited 0 - Fixing the typo exposed more broken steps ## Solution - This PR fixes the errors - Merged the duplicate restore procedures on each page ## Test results - Every step was run exactly as written, on both Docker Compose and a Helm 8.2.0 deployment - No errors - The restored databases are identical to the backups - Sourcegraph's data is restored and verified ## Follow up - [deploy-sourcegraph-docker#1485](sourcegraph/deploy-sourcegraph-docker#1485) adds codeinsights-db to the db-only docker-compose.override.yaml file --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
db-only-migrate.docker-compose.yamlstarts only the databases, for backups, restores, and upgradesProblems
It was never updated to include
codeinsights-dbsince it was newly addedIt had duplicate content, and wasn't kept up to date with
docker-compose.yamlSolutions
All three databases now use
extends, which copies each service's definition fromdocker-compose.yamlsourcegraph/docs#2156 fixes the restore commands on that docs page, and needs this PR
Checklist
Test plan
On a test machine (Docker 29.9.3, Compose 5.7.1): a full 8.2.0 deployment,
down, then this file alone on the same volumes.mainpgsql,codeintel-dbpgsql,codeintel-db,codeinsights-db, nothing elsepg_dumpcommands from the docsNo such container: codeinsights-dbdocker compose -f docker-compose.yaml run --rm --no-deps migratorlookup codeinsights-db ... no such hostSchema(s) are up-to-date!docker-compose config --hashis identical from either file, so the finaldocker-compose up -drecreated none of the three databases. Onmain, it recreatedpgsqlandcodeintel-dbconfig --serviceslists only the three databases on Compose 2.18.1 and 5.7.1Closes FE-580