Repository navigation
ci: Skip the smoke test on branches which only change files it does not read - #1484
Open
marcleblanc2 wants to merge 2 commits into
Open
marcleblanc2 wants to merge 2 commits into
marcleblanc2 wants to merge 2 commits into
Conversation
This was referenced Nov 11, 2026
marcleblanc2
force-pushed
the
marc/skip-smoke-test-on-docs-only
branch
from
November 11, 2026 23:45
53b4957 to
240c5ad
Compare
1 task done
marcleblanc2
force-pushed
the
marc/skip-smoke-test-on-docs-only
branch
from
November 12, 2026 22:56
240c5ad to
e7c0864
Compare
marcleblanc2
force-pushed
the
marc/skip-smoke-test-on-docs-only
branch
from
November 13, 2026 04:58
e7c0864 to
f46a27d
Compare
marcleblanc2
marked this pull request as ready for review
November 13, 2026 05:36
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 05:40
marcleblanc2
changed the title
stacked auto-merge was automatically disabled
November 13, 2026 07:29
Auto-merge was disabled for another pull request in the stack
Builds on main always run it. The step is defined twice, because if_changed compares against the default branch, and finds no changes in a build of main. Amp-Thread-ID: https://ampcode.com/threads/T-01a1c7a5-6b65-723b-980c-b85e1e9008b5 Co-authored-by: Amp <amp@ampcode.com>
…ot read Widens the if_changed exclude list from Markdown to the files the smoke test never reads: GitHub and editor settings, release manifests, Prettier inputs, the Compose files it does not start, and the Caddyfiles the base file leaves commented out. New files still run the smoke test. The executor and Jaeger Compose files and test/executor-smoke-test.sh stay off the list, because #1489 adds them to the smoke test. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1d3ba-ceb2-7220-8dc4-46d20882d955
marcleblanc2
force-pushed
the
marc/skip-smoke-test-on-docs-only
branch
from
November 13, 2026 07:51
b10c3c0 to
eb9ab20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke test boots a VM for 7 to 10 minutes. Branches which only change files it never reads now skip it, such as docs, GitHub settings, release manifests, and example Compose files. The list is in
.buildkite/pipeline.yaml. Builds onmain, and branches which change any other file, still run it.Checklist
Test plan
buildkite-agent pipeline upload --dry-run --changed-files-path: skips for each listed file, runs for everything else the smoke test reads and for new filesCloses FE-588