Skip to content

chore: Remove unused Go tooling - #1466

Merged
michaellzc merged 1 commit into
mainfrom
remove-go-tooling
Nov 10, 2026
Merged

michaellzc merged 1 commit into
mainfrom
remove-go-tooling

Conversation

@michaellzc

Copy link
Copy Markdown
Member

The repo no longer needs any Go. verify-release never checks anything: current release branches (internal/release-*, promote/release-*, release-v*) never match its semver test, so it exits early on every build (e.g. build #16775), and it fails the golang.org/x/mod Renovate PRs. test/upgrade-test.go is a manual tool that no pipeline or other repo runs. This removes both, plus tools/tools.go, the root go.mod/go.sum, the golang pin, and the Go-module Renovate rule.

Checklist

  • All images have a valid tag and SHA256 sum (no image changes)

Test plan

  • yarn prettier-check passes and .buildkite/pipeline.yaml parses; no .go or go.mod files remain.
  • Sourcegraph code search finds no references to upgrade-test.go or verify-release outside this repo.
  • CI on this PR runs the remaining steps.

verify-release never validates anything: current release branches
(internal/release-*, promote/release-*, release-v*) never match its
semver check, so it exits early on every build, and it fails the
golang.org/x/mod Renovate PRs. test/upgrade-test.go was a manual tool
that no pipeline or other repo runs, and tools/tools.go pins a
removed script. With them gone the repo has no Go code, so drop the
root go.mod/go.sum, the golang pin, and the Go-module Renovate rule.

Amp-Thread-ID: https://ampcode.com/threads/T-b3c696f0-d430-4f87-a89d-de9efabfdd7a
Co-authored-by: Amp <amp@ampcode.com>
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

@michaellzc
michaellzc requested review from a team and devdinu November 10, 2026 17:24
@michaellzc
michaellzc enabled auto-merge (squash) November 10, 2026 17:24
@michaellzc
michaellzc merged commit 9ca42d1 into main Nov 10, 2026
3 checks passed
@michaellzc
michaellzc deleted the remove-go-tooling branch November 10, 2026 17:35
marcleblanc2 added a commit that referenced this pull request Nov 10, 2026
…images (#1442)

Renovate's Sourcegraph image PRs here only ever get closed as stale
(#1185, #1186, #1440, and now #1439, #1451): the image tags in
`docker-compose/` are pinned by the release process (`sg ops
update-images` in `release.yaml`), not Renovate. The rest of the config
was from 2020 and used options Renovate has since renamed (#1437).

### Changes

- Extend the shared `sourcegraph/renovate-config` preset, like the other
sourcegraph repos
- Disable updates for `index.docker.io/sourcegraph/*` images; Renovate
will auto-close #1439 and #1451
- Batch minor/patch updates into one weekly PR (`group:allNonMajor` +
`schedule:weekly`); majors still get their own PR
- Drop the per-rule `automerge`

Supersedes #1437. Rebased on #1466, which removed the repo's Go, so this
no longer re-enables Go module updates.

### Checklist

* [x] All images have a valid tag and SHA256 sum (no image changes)

### Test plan

- `renovate-config-validator --strict --no-global renovate.json`
(Renovate 44.151.1) passes
- `prettier --list-different` (the `prettier-check` script) passes
- Local `renovate --platform=local --dry-run=lookup` (Renovate 44.151.1,
`github>` preset) against this branch: all 27
`index.docker.io/sourcegraph/*` image references (23 images) report
`skipReason: disabled`; `@sourcegraph/prettierrc`, `.tool-versions`
(`github-cli`, `shellcheck`, `node`), and `.nvmrc` land in
`renovate/all-minor-patch`; majors (`prettier` 3, Node 26) get separate
branches

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants