Skip to content

chore: Remove sourcegraph/server and pure-docker leftovers - #1433

Merged
marcleblanc2 merged 1 commit into
mainfrom
remove-single-container-leftovers
Nov 10, 2026
Merged

marcleblanc2 merged 1 commit into
mainfrom
remove-single-container-leftovers

Conversation

@marcleblanc2

@marcleblanc2 marcleblanc2 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Problem

  • Docker Compose is the only deployment type this repo still supports, all other deployment types in this repo have been deprecated

  • Much cruft has been left and forgotten in this repo, making it difficult to find which files are used or not

Deleted

  • nginx/ – sourcegraph/server nginx config, unreferenced since 2020

  • tools/migrate.sh, tools/migration_vars – sourcegraph/server → Docker Compose DB migration; the single-container image was removed in 7.0

  • nginx cert lines in .gitignore

Updated

  • db-only-migrate.docker-compose.yaml header – it's for backup/restore, not the server migration

Test plan

  • CI: validate-docker-compose, prettier-check, and the docker-compose-test Vagrant smoke test pass

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

@marcleblanc2 marcleblanc2 changed the title chore: remove single-container and pure-docker leftovers chore: Remove leftovers from deprecated deployment types Oct 14, 2026
@marcleblanc2
marcleblanc2 requested a review from a team October 15, 2026 00:42
@marcleblanc2
marcleblanc2 enabled stacked auto-merge (squash) October 15, 2026 00:42
@marcleblanc2
marcleblanc2 force-pushed the remove-single-container-leftovers branch from 3da7c50 to c818317 Compare October 30, 2026 01:44
@marcleblanc2 marcleblanc2 changed the title chore: Remove leftovers from deprecated deployment types chore: Remove sourcegraph/server and pure-docker leftovers Oct 30, 2026
@marcleblanc2
marcleblanc2 disabled stacked auto-merge October 30, 2026 03:03
@marcleblanc2
marcleblanc2 added this pull request to stack #1458 October 30, 2026 03:03
@marcleblanc2
marcleblanc2 force-pushed the remove-single-container-leftovers branch from c818317 to d360e78 Compare November 9, 2026 23:35
@marcleblanc2
marcleblanc2 enabled stacked auto-merge (squash) November 9, 2026 23:36
stacked auto-merge was automatically disabled November 10, 2026 17:54

Auto-merge was disabled for another pull request in the stack

@marcleblanc2
marcleblanc2 force-pushed the remove-single-container-leftovers branch from d360e78 to 83f7d5b Compare November 10, 2026 18:52
@marcleblanc2
marcleblanc2 enabled stacked auto-merge (squash) November 10, 2026 19:50
stacked auto-merge was automatically disabled November 10, 2026 20:18

Auto-merge was disabled for another pull request in the stack

Docker Compose is the only deployment type this repo supports. #1386
removed pure-docker/; this removes what was still left over for
sourcegraph/server and pure-docker:

- nginx/: sourcegraph/server nginx config, unreferenced since 2020
- tools/migrate.sh, tools/migration_vars: sourcegraph/server to Docker
  Compose DB migration; the single-container image was removed in 7.0
- tools/tools.go: pinned update-docker-tags, whose script was removed
  in #1249; go mod tidy drops it and dev/ci/images
- renovate.json rule for a Go module path that no longer exists
- .gitignore entries for nginx certs
- db-only-migrate.docker-compose.yaml header: it is for backup/restore,
  not the server migration

Amp-Thread-ID: https://ampcode.com/threads/T-01a18a77-bb16-74a4-b42c-bdbad59a3194
Co-authored-by: Amp <amp@ampcode.com>
@marcleblanc2
marcleblanc2 force-pushed the remove-single-container-leftovers branch from 83f7d5b to e0fa885 Compare November 10, 2026 20:22
@marcleblanc2
marcleblanc2 enabled stacked auto-merge (squash) November 10, 2026 20:25
stacked auto-merge was automatically disabled November 10, 2026 20:36

Auto-merge was disabled for another pull request in the stack

@marcleblanc2
marcleblanc2 merged commit cbc4b70 into main Nov 10, 2026
3 checks passed
@marcleblanc2
marcleblanc2 deleted the remove-single-container-leftovers branch November 10, 2026 20:36
marcleblanc2 added a commit to sourcegraph/docs that referenced this pull request Nov 10, 2026
…pt (#2145)

The migration script link on the [single Docker image to Docker Compose
migration
page](https://sourcegraph.com/docs/self-hosted/deploy/docker-compose/migrate#migration-guide)
is a 404:
sourcegraph/deploy-sourcegraph-docker#1433
deleted `tools/migrate.sh` from `main`.

This points the link at `v6.12.5040`, the newest 6.x tag, which still
has the script.

## Test plan

- Old link:
[404](https://github.com/sourcegraph/deploy-sourcegraph-docker/blob/master/tools/migrate.sh)
- New link:
[200](https://github.com/sourcegraph/deploy-sourcegraph-docker/blob/v6.12.5040/tools/migrate.sh)

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants