Conversation
davejrt
approved these changes
Apr 15, 2022
bobheadxi
reviewed
Apr 20, 2022
Dockerfile
Outdated
Comment on lines
5
to
6
| COPY go.mod go.sum *.go ./ | ||
| COPY cmd/ ./cmd |
Member
There was a problem hiding this comment.
Suggested change
| COPY go.mod go.sum *.go ./ | |
| COPY cmd/ ./cmd | |
| COPY go.mod go.sum **/*.go ./ |
I think this works? Otherwise it might be easier to just do
Suggested change
| COPY go.mod go.sum *.go ./ | |
| COPY cmd/ ./cmd | |
| COPY . . |
Contributor
|
@jhchabran Saw this PR by chance, are you still working on getting this merged? |
Author
|
@unknwon not right now as their is another dependent change before this gets merged, but if you need this for any reason, I can fix it and merge it, you tell me :) |
Contributor
|
No rush and keep your pace 👍 I was just checking. |
Contributor
|
Haha, checking again on this, I want to use it as normal Go module in another project. |
These changes enable to import codenotify as a go module and to use the now exported Subscribers function to compute subscribers from Go code rather than having to call the binary. Other than a slight code reorganization to allow that, behaviour remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes enable to import codenotify as a go module and to use the
now exported Subscribers function to compute subscribers from Go code
rather than having to call the binary.
Other than a slight code reorganization to allow that, behavior remains
unchanged.