Skip to content

feat(backend): add configurable concurrency for permission sync jobs#840

Merged
brendan-kellam merged 2 commits intomainfrom
bkellam/permission-concurrency
Feb 2, 2026
Merged

feat(backend): add configurable concurrency for permission sync jobs#840
brendan-kellam merged 2 commits intomainfrom
bkellam/permission-concurrency

Conversation

@brendan-kellam
Copy link
Contributor

@brendan-kellam brendan-kellam commented Feb 2, 2026 •
edited by coderabbitai bot
Loading

Summary

  • Add maxAccountPermissionSyncJobConcurrency and maxRepoPermissionSyncJobConcurrency settings to the config schema
  • Update accountPermissionSyncer and repoPermissionSyncer to use these settings instead of hardcoded concurrency of 1
  • Both settings default to 8, matching other concurrency settings in the codebase

Test plan

  • Verify backend builds successfully
  • Test permission syncing with default concurrency
  • Test permission syncing with custom concurrency values in config

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • New Features
    • Added two new configuration settings (maxAccountPermissionSyncJobConcurrency and maxRepoPermissionSyncJobConcurrency) to control the number of concurrent permission synchronization jobs. Both default to 8, allowing users to optimize performance based on their infrastructure needs.

@github-actions

This comment has been minimized.

Sign in to view
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026 •
edited
Loading

Walkthrough

Adds two new configuration settings for controlling concurrency in permission sync jobs: maxAccountPermissionSyncJobConcurrency and maxRepoPermissionSyncJobConcurrency, both defaulting to 8. The changes update configuration documentation, schema definitions, type definitions, constants, and backend implementation to replace hardcoded concurrency values with the new configurable settings.

Changes

Cohort / File(s) Summary
Changelog & Documentation
CHANGELOG.md, docs/docs/configuration/config-file.mdx		 Added entries documenting the two new configuration settings with default value of 8 and minimum value of 1.
JSON & TypeScript Schemas
packages/schemas/src/v3/index.schema.ts, packages/schemas/src/v3/index.type.ts, schemas/v3/index.json, docs/snippets/schemas/v3/index.schema.mdx		 Extended schema definitions to include the two new numeric configuration properties with descriptions, defaults, and minimum constraints in both TypeScript and JSON schema formats.
Configuration Constants
packages/shared/src/constants.ts		 Added the two new settings to the exported DEFAULT_CONFIG_SETTINGS constant, each set to 8.
Backend Syncers
packages/backend/src/ee/accountPermissionSyncer.ts, packages/backend/src/ee/repoPermissionSyncer.ts		 Updated BullMQ Worker concurrency initialization from hardcoded value of 1 to use the respective configurable settings via this.settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • msukkari
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: adding configurable concurrency settings for permission sync jobs, which is the primary focus of the entire changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bkellam/permission-concurrency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam @claude
docs: add changelog entry for permission sync concurrency settings
fce3fae 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Feb 2, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@claude
Copy link

claude bot commented Feb 2, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@brendan-kellam brendan-kellam merged commit 421c078 into main Feb 2, 2026
11 checks passed
@brendan-kellam brendan-kellam deleted the bkellam/permission-concurrency branch February 2, 2026 07:15
@github-actions github-actions bot mentioned this pull request Feb 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam