fix(worker): skip non-directory paths in file-based git connection config#1049
Merged
brendan-kellam merged 3 commits intomainfrom Mar 26, 2026
Merged
fix(worker): skip non-directory paths in file-based git connection config#1049brendan-kellam merged 3 commits intomainfrom
brendan-kellam merged 3 commits intomainfrom
Conversation
…nfig Fixes #1005 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe changes add validation to ensure local Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brendan-kellam
added a commit
that referenced
this pull request
Mar 26, 2026
… check Mocks fs/promises so tests don't hit the real filesystem. The directory check added in #1049 caused all file-based config tests to fail since fake paths like /path/to/valid/repo don't exist on disk. Also adds a test verifying that a file path (non-directory) produces a warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compileGenericGitHostConfig_filenow checks each matched path withfs.stat()before attempting any git operationsGit.cwd: cannot change to non-directoryerrorTest plan
file://connection with a glob pattern that matches both files and directories and verify files are skipped with a warningFixes #1005
🤖 Generated with Claude Code
Summary by CodeRabbit
file://protocol would fail when the path referenced a file instead of a directory.