Skip to content

feat: Add Docker image build & push workflows#60

Merged
nfebe merged 2 commits into
mainfrom
feat/docker-image-build-workflow
Feb 17, 2026
Merged

feat: Add Docker image build & push workflows#60
nfebe merged 2 commits into
mainfrom
feat/docker-image-build-workflow

Conversation

@nfebe
Copy link
Copy Markdown
Contributor

@nfebe nfebe commented Feb 17, 2026

Add CI workflows for building and pushing base and enterprise images to GHCR, plus Makefile targets for local prod image management.

@sourceant
Copy link
Copy Markdown

sourceant Bot commented Feb 17, 2026

Code Review Summary

This pull request includes a minor but important update to the README.md file, specifically changing the contact email address. This ensures that users and contributors have the most current information to reach the project maintainers.

🚀 Key Improvements

  • Updated contact email address in README.md for improved accuracy.

Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread .github/workflows/build-enterprise-image.yml Outdated
Comment thread Makefile
Comment thread Makefile
Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread .github/workflows/build-image.yml Outdated
Comment thread Makefile
@nfebe nfebe force-pushed the feat/docker-image-build-workflow branch from 2e16478 to 9f9ddfe Compare February 17, 2026 16:16
@sourceant
Copy link
Copy Markdown

sourceant Bot commented Feb 17, 2026

Code Review Summary

This PR introduces robust CI/CD workflows for building and pushing Docker images to GHCR for both standard and enterprise versions. It also enhances the local development experience with new Makefile targets.

🚀 Key Improvements

  • Standardized image metadata and tagging using docker/metadata-action.
  • Automated build-on-push for the main branch.
  • Parameterized enterprise builds via workflow_dispatch.
  • Added configurable IMAGE_NAME and IMAGE_TAG variables in the Makefile.

💡 Minor Suggestions

  • Enable GitHub Actions caching for Docker builds to reduce execution time.
  • Consolidate secret usage to GITHUB_TOKEN where possible.

Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread .github/workflows/build-enterprise-image.yml
@sourceant
Copy link
Copy Markdown

sourceant Bot commented Feb 17, 2026

🔍 Code Review

💡 1. **.github/workflows/build-image.yml** (Line 36) - PERFORMANCE

To significantly improve build times for subsequent runs, consider adding Docker layer caching. This will reuse unmodified layers from previous builds, making your CI/CD process more efficient. GitHub Actions cache (GHA) is a good option for this.

Suggested Code:

      - name: Build and push
        uses: docker/build-push-action@v5
        with:
          context: .
          push: true
          tags: ${{ steps.meta.outputs.tags }}
          labels: ${{ steps.meta.outputs.labels }}
          cache-from: type=gha
          cache-to: type=gha,mode=max

Current Code:

      - name: Build and push
        uses: docker/build-push-action@v5
        with:
          context: .
          push: true
          tags: ${{ steps.meta.outputs.tags }}
          labels: ${{ steps.meta.outputs.labels }}

Verdict: COMMENT

Posted as a comment because posting a review failed.

Add CI workflows for building and pushing base and enterprise images
to GHCR, plus Makefile targets for local prod image management.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/docker-image-build-workflow branch from 9f9ddfe to 5d0072e Compare February 17, 2026 16:51
Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread .github/workflows/build-plugin-image.yml
Comment thread README.md
Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread Makefile
Comment thread Makefile
Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

Copy link
Copy Markdown

@sourceant sourceant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit bdc9b9c into main Feb 17, 2026
1 check passed
@nfebe nfebe deleted the feat/docker-image-build-workflow branch February 17, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant