Skip to content

Modify GNU thumbnailer#1674

Open
wolfpackmars2 wants to merge 2 commits intosolvespace:masterfrom
wolfpackmars2:gnu-thumbnailer
Open

Modify GNU thumbnailer#1674
wolfpackmars2 wants to merge 2 commits intosolvespace:masterfrom
wolfpackmars2:gnu-thumbnailer

Conversation

@wolfpackmars2
Copy link
Contributor

This edit aligns the thumbnailer feature with PR #1673. Specifically, it modifies the solvespace.thumbnail file to point to the installed executable. This means that if a user installs solvespace to ~/.local, the thumbnailer will work for that user.

This is necessary because ~/.local/bin is not normally included in the default PATH environment variable.

@phkahler
Copy link
Member

phkahler commented Feb 4, 2026

I've been thinking about this thumbnailer stuff and I don't think we want it by default for builds - only for "make install" and then preferably as an option. I still think it's more of a packaging thing. I just don't like the idea of saving a file from email or off the internet and having software open it by default.

@ruevs what do you think?

@ruevs
Copy link
Member

ruevs commented Feb 4, 2026

This is quite far from my daily computer use since I do not use (desktop) Linux regularly.

But it definitely sounds like a distro/packaging problem.

Whether the default make install without sudo should be able to set up a "thumbnailer" I have no opinion whatsoever on... It it were my personal machine I couldn't care less - I would never run make install if compiling from source.

@wolfpackmars2
Copy link
Contributor Author

This PR aligns the .thumbnailer with the .desktop file.

I just don't like the idea of saving a file from email or off the internet and having software open it by default.

Is SS so insecure? I am confused by this. So don't use thumbnails then. Every thumbnail operates the same way. I'm so confused I don't even know where to start.

I would never run make install if compiling from source

The alternative being... software compiled by others and installed with root privileges... ?

@ruevs
Copy link
Member

ruevs commented Feb 5, 2026

I would never run make install if compiling from source

The alternative being... software compiled by others and installed with root privileges... ?

What I meant is that when I compile something I simply run it from the location where the compilation process "dumped" the executable. This is perhaps a bit nerdy, but if I've gone to the trouble of compiling the source it means I'm either tracking the bleeding edge of something, or working on it. So "installing" is just an extra step I skip.

This is especially true for SolveSpace, which will happily run from anywhere... on Windows is does not even have an installer - it is a single .exe with no dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants