Skip to content

Qt: Force LC_NUMERIC locale so ReadFloatDecimal will work everywhere.#1649

Merged
ruevs merged 1 commit intosolvespace:masterfrom
WickedSmoke:master
Dec 8, 2025
Merged

Qt: Force LC_NUMERIC locale so ReadFloatDecimal will work everywhere.#1649
ruevs merged 1 commit intosolvespace:masterfrom
WickedSmoke:master

Conversation

@WickedSmoke
Copy link
Contributor

Fixes issue #1646

@ruevs
Copy link
Member

ruevs commented Dec 8, 2025

@WickedSmoke what is ReadFloatDecimaland where is it used? I can not find it neither in guiqt.h nor in guiqt.cpp.
Presumably it has something to do with the settings implementation but I can not find it.

class SettingsImplQt final : public Settings {

@WickedSmoke
Copy link
Contributor Author

It's an ASCIIReader method in resource.cpp which uses strtod().

@WickedSmoke
Copy link
Contributor Author

The Gtk GUI uses setlocale(LC_ALL, "C"), but I was being more conservative.

@ruevs
Copy link
Member

ruevs commented Dec 8, 2025

Thanks for the explanation. I'd never "been in these parts" of SolveSpace.

@ruevs ruevs merged commit 7312dd7 into solvespace:master Dec 8, 2025
3 of 4 checks passed
@ruevs ruevs linked an issue Jan 5, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qt5 UI for SolveSpace

2 participants