group: add an explicit assertion for too many entities#1586
Merged
phkahler merged 1 commit intosolvespace:masterfrom Aug 10, 2025
Merged
group: add an explicit assertion for too many entities#1586phkahler merged 1 commit intosolvespace:masterfrom
phkahler merged 1 commit intosolvespace:masterfrom
Conversation
This makes it clearer to users who are faced with a SolveSpace crash, instead of getting the "handle isn't unique" error from `IdList` much later in a different code-path. While at it, add a minor fix to the documentation of `EntityMap`, which wrongly stated that entities are remapped from requests instead of from groups.
Contributor
Author
|
@ruevs @phkahler, I don't know what the timeline for the 3.2 release is, and even if I'll be able to finish and submit my 64-bit handle works before then, I'm not sure it would be wise to rush its inclusion right before a release. So can we at least merge this in the mean time, in order to make it easier for people to understand what the actual error is instead of crashing later with the |
This was
linked to
issues
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it clearer to users who are faced with a SolveSpace crash, instead of getting the "handle isn't unique" error from
IdListmuch later in a different code-path (prompted by the discussion in #1569).Note that I added it to the code path that adds a new entity into the remap, rather than to
hGroup::entity(), in order to avoid breaking existing models which already go over the limit, like the one in #1569.While at it, add a minor fix to the documentation of
EntityMap, which wrongly stated that entities are remapped from requests instead of from groups.