Made BookStack uploads folder volumable - #2
Merged
Conversation
Owner
|
I really appreciate your work on the image 👍 . Currently I can't say how much impact this will have. The mounting of a volume causes the issue with permissions. I will try to improve this later on the weekend ( I hope that i can afford the time). My next improvement that are planed are:
If you think features will be missing add an issue for that. |
Owner
|
Sorry for the delay I will merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought it would be a good idea to make the uploads folder into a volume so that they can persist like the MySQL data. This makes them easier to back up and it also becomes easier to share the uploads between multiple BookStack docker instances (Not a common requirement but it's fun to see in action). Unfortunately this does require forcing permissions on the upload folder every startup, Hence the entrypoint script change.
I'm not sure how this affects your docker image versioning (I've never published docker images). If it helps I'm likely to be releasing another BookStack bugfix release this weekend which will bump BookStack to version v0.11.2 so this could be merged with that version change if it makes things easier.