fix: replace defineHandler with defineEventHandler#2102
Open
Sigmabrogz wants to merge 3 commits intosolidjs:mainfrom
Open
fix: replace defineHandler with defineEventHandler#2102Sigmabrogz wants to merge 3 commits intosolidjs:mainfrom
Sigmabrogz wants to merge 3 commits intosolidjs:mainfrom
Conversation
Resolves an issue where npm init solid@latest generates an unbuildable template because h3 no longer exports defineHandler. defineEventHandler is the modern API. Signed-off-by: Sigmabrogz <bnb1000bnb@gmail.com>
❌ Deploy Preview for solid-start-landing-page failed. Why did it fail? →
|
🦋 Changeset detectedLatest commit: 6dc2af8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Author
|
I've added the changeset as requested. |
Author
|
Hi maintainers, I've added the changeset as requested. The PR is ready for review. Would appreciate a review when you have time. Thanks! |
brenelz
reviewed
Mar 19, 2026
| options: HandlerOptions | ((context: PageEvent) => HandlerOptions | Promise<HandlerOptions>) = {}, | ||
| ) { | ||
| const handler = defineHandler({ | ||
| const handler = defineEventHandler({ |
Contributor
There was a problem hiding this comment.
is there a reason for this change? Is the old one deprecated?
Contributor
There was a problem hiding this comment.
As the PR description says, H3 no longer exports defineHandler
brenelz
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2101
h3no longer exportsdefineHandler. It was replaced bydefineEventHandler. This updates the import and usage in@solidjs/startso that the generated template is buildable.