This repository was archived by the owner on Sep 17, 2024. It is now read-only.
docs: use consistent and non-ambiguous event handler names#286
Merged
edemaine merged 2 commits intosolidjs:mainfrom Feb 6, 2024
Merged
docs: use consistent and non-ambiguous event handler names#286edemaine merged 2 commits intosolidjs:mainfrom
edemaine merged 2 commits intosolidjs:mainfrom
Conversation
edemaine
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REPL in the tutorial uses ESLint to lint the code and one of the rules, namely
solid/event-handlers, warns on ambiguously named event handlers likeonclickoronchange. This PR changes the event handler names inlesson.jsonandsolved.jsonfiles accordingly. I also foundoninputin the "Rendering" guides, changed this toonInputas well for the sake of consistency.NB. Wow, GitHub diff kinda sucks since it doesn't show specific changes in long lines. Sorry about that.