Skip to content

I166#170

Merged
sufftea merged 7 commits into
masterfrom
i166
May 2, 2024
Merged

I166#170
sufftea merged 7 commits into
masterfrom
i166

Conversation

@sufftea

@sufftea sufftea commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@solid-vovabeloded solid-vovabeloded left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @sufftea! I've added a couple of suggestions here - please, take a look.

Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
@solid-vovabeloded

Copy link
Copy Markdown
Collaborator

Also, please, update the CHANGELOG.md file with the changes you made.

@solid-vovabeloded solid-vovabeloded left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more wording improvements and you'll be good to go. Great job!

Comment thread CHANGELOG.md Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
Comment thread lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart Outdated
@sufftea sufftea merged commit e5fb3e9 into master May 2, 2024
@sufftea sufftea deleted the i166 branch May 2, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants