Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solid-software/solid_lints
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: solid-software/solid_lints
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: analysis_server_migration
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 59 files changed
  • 6 contributors

Commits on Apr 15, 2026

  1. Migrate/avoid global state (#227)

    * Add analysis_server_plugin dependency
    
    * Migrate avoid_global_state rule and tests
    
    * applied code review suggestions
    
    * applied suggestions from code review
    
    * edited main documentation and changed avoid_global_state visitor naming
    Islam-Shaaban-Ibrahim authored Apr 15, 2026
    Configuration menu
    Copy the full SHA
    9b70b6e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2026

  1. migrated avoid non null assertion rule and tests (#230)

    * migrated avoid non null assertion rule and tests
    
    * applied code review suggestions
    
    * applied code review suggestions  regarding  making lintCode private
    Islam-Shaaban-Ibrahim authored Apr 16, 2026
    Configuration menu
    Copy the full SHA
    87f0bd5 View commit details
    Browse the repository at this point in the history
  2. Migrate/avoid debug print in release mode (#228)

    * Add analysis_server_plugin dependency
    
    * Migrate avoid_global_state rule and tests
    
    * applied code review suggestions
    
    * applied code review suggestions
    
    * applied suggestions from code review
    
    * migrated avoid debug print in release and tests
    
    * edited main documentation and changed avoid_global_state visitor naming
    
    * fixed main.dart conflict
    
    * applied suggestions from review
    
    * refactored code according to suggestions from review
    
    * applied code review suggestions
    
    * applied latest changes according to code review
    
    * remove unnecessary comments in AvoidDebugPrintInReleaseVisitor
    Islam-Shaaban-Ibrahim authored Apr 16, 2026
    Configuration menu
    Copy the full SHA
    1119f5c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2026

  1. Migrate/proper super calls (#229)

    * Migrate avoid_global_state rule and tests
    
    * applied code review suggestions
    
    * migrated avoid debug print in release and tests
    
    * applied suggestions from code review
    
    * edited main documentation and changed avoid_global_state visitor naming
    
    * migrated proper super calls rule and tests
    
    * registered ProperSuperCallsRule in the Plugin
    
    * applied code review suggestions
    
    * Fix tests structure
    
    * Remove unnecessary file
    
    ---------
    
    Co-authored-by: vova-beloded-solid <vova.beloded@solid.software>
    Islam-Shaaban-Ibrahim and solid-vovabeloded authored Apr 21, 2026
    Configuration menu
    Copy the full SHA
    04a0112 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2026

  1. Migrated prefer_early_return and its tests (#233)

    * Updated prefer_early_return rule and its visitor to use AnalysisRule .
    
    * Added tests and fixed visitor for prefer early return
    
    * Added the suggested changes
    Dariaa14 authored Apr 23, 2026
    Configuration menu
    Copy the full SHA
    7a8bcfe View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2026

  1. Migrate avoid unnecessary return variable rule and its tests (#237)

    * Updated avoid_unnecessary_return_variable rule and its visitor to use AnalysisRule.
    
    * Updated tests for avoid_unnecessary_return_variable rule
    
    * Deleted previous test file for avoid_unnecessary_return_variable rule.
    
    * Updated ReturnVariableUsageVisitor description.
    
    * Updated avoid_unnecessary_return_variable visitor from recursive to simple visitor.
    
    * Address PR suggestions
    
    * Updated rule to private in the visitor.
    daria-trusca-solid authored Jun 4, 2026
    Configuration menu
    Copy the full SHA
    2006202 View commit details
    Browse the repository at this point in the history
  2. Migrate avoid unnecessary set state rule and its tests (#238)

    * Updated avoid_unnecessary_set_state rule and its visitor to use AnalysisRule.
    
    * Fixed previous commit.
    
    * Updated tests for avoid_unnecessary_set_state rule.
    
    * Delete previous test file for avoid_unnecessary_set_state rule
    
    * Updated the avoid_unnecessary_set_state visitor from recursive to simple.
    
    * Removed unnecessary set up from avoid_unnecessary_set_state rule tests
    
    * Update lib/src/lints/avoid_unnecessary_setstate/avoid_unnecessary_set_state_rule.dart
    
    Co-authored-by: danylo-safonov-solid <116712879+danylo-safonov-solid@users.noreply.github.com>
    
    * Address PR suggestions
    
    * Updated sdk requirements
    
    * Updated rule to private in visitor
    
    ---------
    
    Co-authored-by: danylo-safonov-solid <116712879+danylo-safonov-solid@users.noreply.github.com>
    Configuration menu
    Copy the full SHA
    5bcbbf0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2026

  1. migrate prefer early return rule with tests (#232)

    * migrate prefer early return rule with tests
    
    * fix: remove flutter dependency to allow running reflective tests
    
    * test: migrate all old tests
    
    * feat: migrate old lint code
    improve readability when possible
    
    * refactor: extract variable for readability
    
    * style: formatting
    
    * test: remove unnecessary test file
    test: add nested 3 ifs test case
    
    ---------
    
    Co-authored-by: Andrew Bekhiet <andrew.bekhiet@solid.software>
    Configuration menu
    Copy the full SHA
    adfd585 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2026

  1. Migrate avoid unrelated type assertions and its tests (#239)

    * Updated avoid_unrelated_type_assertions and its visitor to use AnalysisRule.
    
    * Updated tests for avoid_unrelated_type_assertions rule
    
    * Delete previous test file for avoid_unrelated_type_assertions
    
    * Update variable modifiers to private
    
    * Updated avoid_unrelared_type_assertions visitor from recursive to simple
    daria-trusca-solid authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    be820c7 View commit details
    Browse the repository at this point in the history
  2. Migrate newline before return rule and its tests (#240)

    * Updated newline_before_return_visitor rule and its visitor
    
    * Merged tests for newline_return_rule
    
    * Delete previous test file for newline_before_return
    
    * Updated min version of sdk
    
    * Added safety handle for the null case
    
    * Update newline_before_return_rule_test.dart
    
    * Added test for multiple comments and for a newline before a comment.
    daria-trusca-solid authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    7e8403a View commit details
    Browse the repository at this point in the history
  3. Migrate no equal then else rule and its tests (#241)

    * Updated no_equal_then_else rule and its visitor
    
    * Merged tests for no_equal_then_else rule
    
    * Delete previous test file for no_equal_then_else
    
    * Applied PR suggestions from Gemini
    daria-trusca-solid authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    4a31bb2 View commit details
    Browse the repository at this point in the history
  4. refactor: migrate double_literal_format to analysis_server_plugin (#281)

    * refactor: migrate double_literal_format to analysis_server_plugin
    docs: improve code docs
    
    * fix: handle literals with capital E
    test: handle exponentials in test cases
    
    * fix: include unnecessary leading zeroes in lint description
    andrew-bekhiet-solid authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    e5eef63 View commit details
    Browse the repository at this point in the history
  5. Implementation of parameter parser (#234)

    * Created analysis_options.yaml rules parser
    
    * Improved yaml parser and added the analysis_options loader
    
    * Improved rules loader from yaml
    
    * Added verification before looking for .yaml's path
    
    * Fields and getters are now declared before the constructor
    
    * Added method to get options of a rule by it's name
    
    * Made suggested changes to file upward finder
    
    * Removed top-level variable
    
    * Improved name of variable in loadRuleFromContext
    
    * Updated analysis options to have rules for each configuration file path
    
    * Updated file upward finder to not mix File from dart.io with file from analyzer
    
    * Added usage example in avoid_global_state_rule
    
    * style: move getters and fields before constructor
    
    * style: improve readability
    
    * fix: don't parse enabled if the rule has configured options
    style: improve variable names
    refactor: use root package path instead of library path
    refactor: use pattern matching to reduce nesting
    
    * feat: reload rules from file if newer
    refactor: allow mocking resource provider
    refactor: extract CachedPackageRules model
    
    * test: add AnalysisOptionsLoaderTest
    
    * feat(SolidLintRule): add parameter parsing
    refactor: use Map<String, Object?> instead of LintOptions
    as the enabled field is implicitly true for all rules that the analyzer processes
    remove RuleConfig as it is no longer needed
    
    * fix: use Map<String, Object?> for raw rule config
    
    * fix: method name
    
    * fix: make sure rules options are loaded before getting parameters
    
    * refactor: remove unused AnalysisOptionsLoader from AvoidGlobalStateRule
    refactor: use for loop to register rules
    
    * refactor: extract duplicate logic
    
    ---------
    
    Co-authored-by: Andrew Bekhiet <andrew.bekhiet@solid.software>
    Dariaa14 and andrew-bekhiet-solid authored Jun 10, 2026
    Configuration menu
    Copy the full SHA
    1cd1032 View commit details
    Browse the repository at this point in the history
Loading