-
Notifications
You must be signed in to change notification settings - Fork 24
Comparing changes
Open a pull request
base repository: solid-software/solid_lints
base: master
head repository: solid-software/solid_lints
compare: analysis_server_migration
- 13 commits
- 59 files changed
- 6 contributors
Commits on Apr 15, 2026
-
Migrate/avoid global state (#227)
* Add analysis_server_plugin dependency * Migrate avoid_global_state rule and tests * applied code review suggestions * applied suggestions from code review * edited main documentation and changed avoid_global_state visitor naming
Configuration menu - View commit details
-
Copy full SHA for 9b70b6e - Browse repository at this point
Copy the full SHA 9b70b6eView commit details
Commits on Apr 16, 2026
-
migrated avoid non null assertion rule and tests (#230)
* migrated avoid non null assertion rule and tests * applied code review suggestions * applied code review suggestions regarding making lintCode private
Configuration menu - View commit details
-
Copy full SHA for 87f0bd5 - Browse repository at this point
Copy the full SHA 87f0bd5View commit details -
Migrate/avoid debug print in release mode (#228)
* Add analysis_server_plugin dependency * Migrate avoid_global_state rule and tests * applied code review suggestions * applied code review suggestions * applied suggestions from code review * migrated avoid debug print in release and tests * edited main documentation and changed avoid_global_state visitor naming * fixed main.dart conflict * applied suggestions from review * refactored code according to suggestions from review * applied code review suggestions * applied latest changes according to code review * remove unnecessary comments in AvoidDebugPrintInReleaseVisitor
Configuration menu - View commit details
-
Copy full SHA for 1119f5c - Browse repository at this point
Copy the full SHA 1119f5cView commit details
Commits on Apr 21, 2026
-
Migrate/proper super calls (#229)
* Migrate avoid_global_state rule and tests * applied code review suggestions * migrated avoid debug print in release and tests * applied suggestions from code review * edited main documentation and changed avoid_global_state visitor naming * migrated proper super calls rule and tests * registered ProperSuperCallsRule in the Plugin * applied code review suggestions * Fix tests structure * Remove unnecessary file --------- Co-authored-by: vova-beloded-solid <vova.beloded@solid.software>
Configuration menu - View commit details
-
Copy full SHA for 04a0112 - Browse repository at this point
Copy the full SHA 04a0112View commit details
Commits on Apr 23, 2026
-
Migrated prefer_early_return and its tests (#233)
* Updated prefer_early_return rule and its visitor to use AnalysisRule . * Added tests and fixed visitor for prefer early return * Added the suggested changes
Configuration menu - View commit details
-
Copy full SHA for 7a8bcfe - Browse repository at this point
Copy the full SHA 7a8bcfeView commit details
Commits on Jun 4, 2026
-
Migrate avoid unnecessary return variable rule and its tests (#237)
* Updated avoid_unnecessary_return_variable rule and its visitor to use AnalysisRule. * Updated tests for avoid_unnecessary_return_variable rule * Deleted previous test file for avoid_unnecessary_return_variable rule. * Updated ReturnVariableUsageVisitor description. * Updated avoid_unnecessary_return_variable visitor from recursive to simple visitor. * Address PR suggestions * Updated rule to private in the visitor.
Configuration menu - View commit details
-
Copy full SHA for 2006202 - Browse repository at this point
Copy the full SHA 2006202View commit details -
Migrate avoid unnecessary set state rule and its tests (#238)
* Updated avoid_unnecessary_set_state rule and its visitor to use AnalysisRule. * Fixed previous commit. * Updated tests for avoid_unnecessary_set_state rule. * Delete previous test file for avoid_unnecessary_set_state rule * Updated the avoid_unnecessary_set_state visitor from recursive to simple. * Removed unnecessary set up from avoid_unnecessary_set_state rule tests * Update lib/src/lints/avoid_unnecessary_setstate/avoid_unnecessary_set_state_rule.dart Co-authored-by: danylo-safonov-solid <116712879+danylo-safonov-solid@users.noreply.github.com> * Address PR suggestions * Updated sdk requirements * Updated rule to private in visitor --------- Co-authored-by: danylo-safonov-solid <116712879+danylo-safonov-solid@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5bcbbf0 - Browse repository at this point
Copy the full SHA 5bcbbf0View commit details
Commits on Jun 8, 2026
-
migrate prefer early return rule with tests (#232)
* migrate prefer early return rule with tests * fix: remove flutter dependency to allow running reflective tests * test: migrate all old tests * feat: migrate old lint code improve readability when possible * refactor: extract variable for readability * style: formatting * test: remove unnecessary test file test: add nested 3 ifs test case --------- Co-authored-by: Andrew Bekhiet <andrew.bekhiet@solid.software>
Configuration menu - View commit details
-
Copy full SHA for adfd585 - Browse repository at this point
Copy the full SHA adfd585View commit details
Commits on Jun 10, 2026
-
Migrate avoid unrelated type assertions and its tests (#239)
* Updated avoid_unrelated_type_assertions and its visitor to use AnalysisRule. * Updated tests for avoid_unrelated_type_assertions rule * Delete previous test file for avoid_unrelated_type_assertions * Update variable modifiers to private * Updated avoid_unrelared_type_assertions visitor from recursive to simple
Configuration menu - View commit details
-
Copy full SHA for be820c7 - Browse repository at this point
Copy the full SHA be820c7View commit details -
Migrate newline before return rule and its tests (#240)
* Updated newline_before_return_visitor rule and its visitor * Merged tests for newline_return_rule * Delete previous test file for newline_before_return * Updated min version of sdk * Added safety handle for the null case * Update newline_before_return_rule_test.dart * Added test for multiple comments and for a newline before a comment.
Configuration menu - View commit details
-
Copy full SHA for 7e8403a - Browse repository at this point
Copy the full SHA 7e8403aView commit details -
Migrate no equal then else rule and its tests (#241)
* Updated no_equal_then_else rule and its visitor * Merged tests for no_equal_then_else rule * Delete previous test file for no_equal_then_else * Applied PR suggestions from Gemini
Configuration menu - View commit details
-
Copy full SHA for 4a31bb2 - Browse repository at this point
Copy the full SHA 4a31bb2View commit details -
refactor: migrate double_literal_format to analysis_server_plugin (#281)
* refactor: migrate double_literal_format to analysis_server_plugin docs: improve code docs * fix: handle literals with capital E test: handle exponentials in test cases * fix: include unnecessary leading zeroes in lint description
Configuration menu - View commit details
-
Copy full SHA for e5eef63 - Browse repository at this point
Copy the full SHA e5eef63View commit details -
Implementation of parameter parser (#234)
* Created analysis_options.yaml rules parser * Improved yaml parser and added the analysis_options loader * Improved rules loader from yaml * Added verification before looking for .yaml's path * Fields and getters are now declared before the constructor * Added method to get options of a rule by it's name * Made suggested changes to file upward finder * Removed top-level variable * Improved name of variable in loadRuleFromContext * Updated analysis options to have rules for each configuration file path * Updated file upward finder to not mix File from dart.io with file from analyzer * Added usage example in avoid_global_state_rule * style: move getters and fields before constructor * style: improve readability * fix: don't parse enabled if the rule has configured options style: improve variable names refactor: use root package path instead of library path refactor: use pattern matching to reduce nesting * feat: reload rules from file if newer refactor: allow mocking resource provider refactor: extract CachedPackageRules model * test: add AnalysisOptionsLoaderTest * feat(SolidLintRule): add parameter parsing refactor: use Map<String, Object?> instead of LintOptions as the enabled field is implicitly true for all rules that the analyzer processes remove RuleConfig as it is no longer needed * fix: use Map<String, Object?> for raw rule config * fix: method name * fix: make sure rules options are loaded before getting parameters * refactor: remove unused AnalysisOptionsLoader from AvoidGlobalStateRule refactor: use for loop to register rules * refactor: extract duplicate logic --------- Co-authored-by: Andrew Bekhiet <andrew.bekhiet@solid.software>
Configuration menu - View commit details
-
Copy full SHA for 1cd1032 - Browse repository at this point
Copy the full SHA 1cd1032View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...analysis_server_migration